notification sent to the wrong receipient

[r.sokoll@…]

(asked on the users-ML, but no anser so far)

If a ticket owner changes, notifications still are sent to the old owner.

Steps to reproduce:

• create a new environment
• set up 3 different users (in this example, lets name them "supervisor", "engineer", "user"
• give "supervisor" TRAC_ADMIN, "engineer" TICKET_MODIFY and "anonymous" TICKET_CREATE permissions
• create 2 components:
  • "new" with owner "supervisor"
  • "assigned" without an owner
• configure notification in trac.ini:

    [notification]
    always_notify_owner = true
    always_notify_reporter = true
    always_notify_updater = false
    smtp_enabled = true
    [ticket]
    default_component = new
  

• "user" creates a ticket
• emails are sent to:
  • "user" (correct, as he is reporter)
  • "supervisor" (correct, as he is owner)
• "supervisor" reassigns the ticket to "engineer" and changes component from "new" to "assigned"
• emails are sent to:
  • "engineer" (correct, as he is owner)
  • "user" (correct, as he is reporter)
• "engineer" accepts the ticket
• emails are sent to:
  • "engineer" (correct, as he is owner)
  • "user" (correct, as he is reporter)
  • "supervisor" (wrong)
• "engineer" resolves the issue and closes the ticket
• emails are sent to:
  • "engineer" (correct, as he is owner)
  • "user" (correct, as he is reporter)
  • "supervisor" (wrong)

The question is, why in the last 2 steps also "supervisor" gets notified. This should not happen, since he is neither owner nor reporter.

[Christian Boos]

Yes, we should look into this, but the severity is probably not critical (as it would be if, e.g. the notification could would prevent the whole ticket subsystem from working).

[anonymous]

This glorious ( ;-)) patch solved the problem for me, can someone more experienced please have a look at this?

diff notification.py notification.py.orig 
224c224
<         if notify_updater:
---
>         if notify_reporter:

[Emmanuel Blot]

The patch makes sense, as the conditional SQL query is about change authors - that is updaters.

Applied in [5160] for 0.10.4 and [5161] for 0.11. Thanks to anonymous.