Edgewall Software
Modify

Opened 17 years ago

Closed 17 years ago

#4391 closed defect (fixed)

wrong title for date prefs (0.11 trunk)?

Reported by: wkornewald Owned by: Jonas Borgström
Priority: low Milestone: 0.11
Component: general Version: devel
Severity: trivial Keywords:
Cc: wkornewald Branch:
Release Notes:
API Changes:
Internal Changes:

Description

It says: <title>Keyboard Shortcuts</title>

Attachments (1)

datetime_prefs_title.diff (420 bytes ) - added by Waldemar Kornewald <wkornewald> 17 years ago.
patch against trunk :)

Download all attachments as: .zip

Change History (8)

comment:1 by Christian Boos, 17 years ago

Well, it works fine for me with Genshi 0.4dev-r467: The title is: Preferences: Keyboard Shortcuts – Trac Devel – Trac:.

It should also probably work with Genshi:milestone:0.3.6.

If you have a recent Trac trunk, you can go in About / System Configuration to check for the actual versions used.

Other points to check:

  • do you have local modifications to your templates?
  • are you sure you're using up-to-date templates? (beware of the [trac] templates_dir issue)

If the problem persists, you could attach the html source for that page here.

Lastly, if you use any site.html, please attach it as well.

comment:2 by wkornewald, 17 years ago

But the date prefs should say "Date Preferences", not "Keyboard Shortcuts".

comment:3 by Christian Boos, 17 years ago

Ah! Sorry, when I saw <title>...</title> I focused on that and thought you actually saw the markup itself :P)

Yeah, sure you're right.

comment:4 by wkornewald, 17 years ago

Hehe. :)

by Waldemar Kornewald <wkornewald>, 17 years ago

Attachment: datetime_prefs_title.diff added

patch against trunk :)

comment:5 by Waldemar Kornewald <wkornewald>, 17 years ago

Maybe you could give me svn access for those small bugs I find every now and then? And maybe also for bigger things like the user API in #2456. :)

comment:6 by Christian Boos, 17 years ago

I finally managed to do it myself ;) See attachment:ticket:975:timeline_link_resolver-r4452.diff

The fix is part of larger changes. I'll probably commit separately the bug fixes from the enhancements, though.

As for the commit access, small fixes would probably be OK I guess, but for the user API I think we really need to see more code, then eventually we could make a branch, etc. Better discuss those things on Trac-Dev anyway.

comment:7 by Christian Boos, 17 years ago

Resolution: fixed
Status: newclosed

Fixed in r4646.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.