[PATCH] Sending of notification fails using .local top level domain

[vandomburg@…]

Having recently updated our Trac 0.9 installation to 0.10, we found the e-mail notification to be broken. As it turns out, 0.10 validates all e-mail addresses and our address (mailinglist@…) did not validate. Reason: .local is longer than 4 characters.

The attached patch fixes this issue and allows the entire domain to contain a maximum of 255 characters as per RFC 2821. Not only is this standard compliant, it is also usual for company intranets like our own to have longer domain names. In fact, all Windows SBS installations come with .local as default top level domain.

[vandomburg@…]

Patch trac/notification.py to validate domains with a maximum of 255 characters

[Emmanuel Blot]

Actually, the regular expression is far from being fully valid, see comment:ticket:3212:2.

I'm not sure about the best way to handle this issue.

[Christian Boos]

Not sure either about the "perfect" solution, but the patch looks useful.

[Emmanuel Blot]

There is some confusion about the proposed patch:

• A FQDN should be 255 character long, max. The proposed patch would allow a 255 char long label, where RFC1035 states that it should be 63 char long or less.

[Emmanuel Blot]

Alternative proposition implemented in [5516]

Add the following option to your trac.ini file:

[notification]
admit_domains = local

For the duplicate issue as submitted in comment:ticket:3212:15, the option would look like

[notification]
admit_domains = localhost, hostname.localdomain, mail.vztech