Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#4372 closed defect (fixed)

[PATCH] Sending of notification fails using .local top level domain

Reported by: vandomburg@… Owned by: Emmanuel Blot
Priority: normal Milestone: 0.11
Component: notification Version: 0.10.2
Severity: minor Keywords:
Cc: pzn@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Having recently updated our Trac 0.9 installation to 0.10, we found the e-mail notification to be broken. As it turns out, 0.10 validates all e-mail addresses and our address (mailinglist@…) did not validate. Reason: .local is longer than 4 characters.

The attached patch fixes this issue and allows the entire domain to contain a maximum of 255 characters as per RFC 2821. Not only is this standard compliant, it is also usual for company intranets like our own to have longer domain names. In fact, all Windows SBS installations come with .local as default top level domain.

Attachments (1)

maximum_domain_length.patch (511 bytes ) - added by vandomburg@… 15 years ago.
Patch trac/notification.py to validate domains with a maximum of 255 characters

Download all attachments as: .zip

Change History (6)

by vandomburg@…, 15 years ago

Attachment: maximum_domain_length.patch added

Patch trac/notification.py to validate domains with a maximum of 255 characters

comment:1 by Emmanuel Blot, 15 years ago

Keywords: notification added

Actually, the regular expression is far from being fully valid, see comment:ticket:3212:2.

I'm not sure about the best way to handle this issue.

comment:2 by Christian Boos, 15 years ago

Component: generalnotification
Milestone: 0.12
Owner: changed from Jonas Borgström to Emmanuel Blot
Severity: normalminor

Not sure either about the "perfect" solution, but the patch looks useful.

comment:3 by Emmanuel Blot, 15 years ago

Status: newassigned

There is some confusion about the proposed patch:

  • A FQDN should be 255 character long, max. The proposed patch would allow a 255 char long label, where RFC1035 states that it should be 63 char long or less.

comment:4 by Emmanuel Blot, 15 years ago

Keywords: notification removed
Milestone: 0.120.11
Resolution: fixed
Status: assignedclosed

Alternative proposition implemented in [5516]

Add the following option to your trac.ini file:

[notification]
admit_domains = local

For the duplicate issue as submitted in comment:ticket:3212:15, the option would look like

[notification]
admit_domains = localhost, hostname.localdomain, mail.vztech

comment:5 by anonymous, 15 years ago

Cc: pzn@… added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Emmanuel Blot.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Emmanuel Blot to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.