Edgewall Software
Modify

Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#4143 closed defect (worksforme)

JavaScript error on wiki pages

Reported by: Noah Kantrowitz (coderanger) <coderanger@…> Owned by: Matthew Good
Priority: low Milestone:
Component: wiki system Version: 0.10
Severity: trivial Keywords:
Cc: alarionov3@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

There is a JavaScript error in the addLinks function, title has no properties. This is because in the wiki template, addHeadingLinks is only called with one argument.

Attachments (0)

Change History (8)

comment:1 by Matthew Good, 16 years ago

Milestone: 0.110.10.2
Owner: changed from Jonas Borgström to Matthew Good

#3729 has been marked as a duplicate.

comment:2 by Larionov Andrey <alarionov3@…>, 16 years ago

Cc: alarionov3@… added

Is this bug a so hard fixing. Maybe it can be fast fixed and ported in 0.10 branch or maybe you can provide temporary patch.

My users are tired of IE error message.

comment:3 by Christian Boos, 16 years ago

Milestone: 0.10.3
Resolution: worksforme
Status: newclosed

This is because in the wiki template, addHeadingLinks is only called with one argument.

Really? That was changed a long time ago: [3564/trunk/templates/wiki.cs]. You're probably using customized templates, check what your TracIni setting is:

[trac]
templates_dir = /path/to/your/templates

and compare those templates with the "official" ones.

Anyway, if someone has the error in his modified template, the changeset linked above should be enough for showing how to fix this problem.

comment:4 by Larionov Andrey <alarionov3@…>, 16 years ago

Sounds strange, but my template is up to date. I chek trac.ini. Path to templates is correct. But in page source (in browser) there is
addHeadingLinks(document.getElementById("searchable"));
instead of addHeadingLinks(document.getElementById("searchable"), "Link to this section");

comment:5 by Christian Boos, 16 years ago

Well, try to modify the template you think is getting used (add some random <h1>HELLO!</h1>) and see if that shows up…

comment:6 by Larionov Andrey <alarionov3@…>, 16 years ago

There is no results on page. I'm using FastCGI frontend. Mybe ClearSilver is caching templates?

comment:7 by Christian Boos, 16 years ago

I've never used FastCGI myself, but I guess that you need a server restart.

comment:8 by Larionov Andrey <alarionov3@…>, 16 years ago

I'm restart server twice

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Matthew Good.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Matthew Good to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.