Opened 18 years ago
Closed 18 years ago
#4138 closed defect (fixed)
Links points wrong in a heading
Reported by: | Owned by: | Christian Boos | |
---|---|---|---|
Priority: | low | Milestone: | 0.11 |
Component: | wiki system | Version: | devel |
Severity: | minor | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
Overview Description: The href of a link in a heading points outside the environment.
Steps to Reproduce:
- Edit any page
- Insert "= [wiki:foo Foo] ="
- Save page
Actual Results: All seems fine except the href: http://a-domain.com/wiki/foo
Expected Results: http://a-domain.com/my_env/wiki/foo
Attachments (0)
Change History (8)
comment:1 by , 18 years ago
follow-up: 3 comment:2 by , 18 years ago
Changing the base_url helps. Why is this necessary when everything else works without this?
comment:3 by , 18 years ago
Component: | general → wiki |
---|---|
Milestone: | → 0.11 |
Owner: | changed from | to
Status: | new → assigned |
Well, because it's a tiny bug ;)
follow-up: 5 comment:4 by , 18 years ago
Fixed in r4245, but as Emmanuel said, the base_url
setting is now nearly mandatory. Perhaps this should be made more apparent in the docs.
I think we should start a TracDev/ReleaseNotes/0.11 page…
comment:5 by , 18 years ago
Replying to cboos:
Fixed in r4245, but as Emmanuel said, the
base_url
setting is now nearly mandatory. Perhaps this should be made more apparent in the docs.
I don't know the internal details so the following suggestion might not be applicable: would there be any way to infer the actual value from other parameters such as TracUriRoot
? It seems that the base url parameter needs to be replicated in both the web server configuration file and the trac configuration file, maybe one of them could be retrieved from the other one?
follow-up: 7 comment:6 by , 18 years ago
The base_url
information is effectively derived from the web server configuration in a few situations, and can also be generally recovered from the URL itself (see source:trunk/trac/web/api.py@4245#L152), but there are a few situations where we don't have access to the req
, and then the only possibility is to use directly env.abs_href
which makes use of the base_url
info.
comment:7 by , 18 years ago
Replying to cboos:
there are a few situations where we don't have access to the
req
, and then the only possibility is to use directlyenv.abs_href
which makes use of thebase_url
info.
I'm pretty sure I miss an important point, but base_url
is not tied to a request: it's a static value. Is there no possibiilty to retrieve this value at startup and keep it in the environment, for example?
comment:8 by , 18 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Actual problem fixed in r4245. If needed, the base_url
discussion should be moved elsewhere…
Double check that your
base_url
option is well defined in yourtrac.ini
file. See also #4105.