Edgewall Software
Modify

Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#4070 closed defect (duplicate)

cannot view all displayed data

Reported by: theultramage@… Owned by: Matthew Good
Priority: normal Milestone:
Component: version control/changeset view Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

When viewing changesets/diffs that have long lines, often the text does not wrap around, but instead gets cut off. That forces me to use another method to view the differences for that file.

Attached is a preview of how such a page looks like.

Attachments (0)

Change History (9)

in reply to:  description comment:1 by anonymous, 18 years ago

PS: I'm unable to attach the file. You can find it at my webserver

The error:

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 356, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 224, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/lib/python2.4/site-packages/trac/attachment.py", line 361, in process_request
    self._do_save(req, attachment)
  File "/usr/lib/python2.4/site-packages/trac/attachment.py", line 474, in _do_save
    for field, message in manipulator.validate_attachment(req, attachment):
  File "build/bdist.linux-x86_64/egg/tracspamfilter/adapters.py", line 130, in validate_attachment
  File "build/bdist.linux-x86_64/egg/tracspamfilter/api.py", line 131, in test
  File "build/bdist.linux-x86_64/egg/tracspamfilter/model.py", line 119, in insert
  File "/usr/lib/python2.4/site-packages/trac/db/util.py", line 47, in execute
    return self.cursor.execute(sql_escape_percent(sql), args)
  File "/usr/lib/python2.4/site-packages/trac/db/util.py", line 47, in execute
    return self.cursor.execute(sql_escape_percent(sql), args)
ProgrammingError: current transaction is aborted, commands ignored until end of transaction block

comment:2 by Christian Boos, 18 years ago

Component: changeset viewspamfilter
Keywords: needinfo added
Owner: changed from Christian Boos to Matthew Good

Sorry, that's pretty vague, what "other method to view the differences for that file"?

Also, it seems that the error happens in the SpamFilter, while trying to validate an attachment. What particular version of Trac and version of SpamFilter do you use?

comment:3 by Christian Boos, 18 years ago

Milestone: 0.10.1
Priority: normalhigh

That error seems to happen also here, see on #2410 for example.

in reply to:  2 comment:4 by Christian Boos, 18 years ago

Component: spamfilterchangeset view
Keywords: needinfo removed
Milestone: 0.10.1
Priority: highnormal
Resolution: duplicate
Status: newclosed

Replying to cboos:

… What particular version of Trac and version of SpamFilter do you use?

Well, I must have been the only one to not see that the traceback was happening in t.e.o's Trac ;) There's now a dedicated ticket for the issue with the attachment: see #4087.

So back to the original request: this has been discussed before, see #3052, #1420. In particular, #1420 seems to have been closed wrongly, as the reported problem, similar to yours, is still present.

I'll reopen it.

comment:5 by anonymous, 18 years ago

That glitch was happening since I started using trac (0.8), and is still there in latest devel #4231. My trac installation is only for viewing local svk mirrors, so I'm not using anything that doesn't get configured automatically during installation. Here you can view the changes in question (trac 0.10).

To me it looks as if there's no line wrapping and the horizontal scrollbar is disabled (so you can't see the data). If viewed correctly, I estimate it should wrap to about 2 or three lines.

in reply to:  5 comment:6 by Christian Boos, 18 years ago

Replying to anonymous:

Here you can view the changes in question (trac 0.10).

No, works fine for me. Did you try to force reload in your browser. Changesets are cached. If you still have an issue with some specific changeset, then please provide the changeset numbers (and line numbers).

To me it looks as if there's no line wrapping and the horizontal scrollbar is disabled (so you can't see the data). If viewed correctly, I estimate it should wrap to about 2 or three lines.

There's no scrollbar on purpose, and as said above, it actually does wrap to 2 or 3 lines when needed.

comment:7 by theultramage@…, 18 years ago

Argh, wrong url; it was supposed to be mob_db.txt

For an example changeset, try this one. I viewed it with Opera, IE and Firefox to make sure. Everywhere it's the same result. Either it just cuts off the line (the first two blocks), or it weakly tries to fake wrapping where it finds a space character (the last block). You can also see how the highlighted text continues to the right.

in reply to:  7 ; comment:8 by Matthew Good, 18 years ago

Replying to theultramage@gmail.com:

For an example changeset, try this one.

You're still running Trac 0.10. The fix cboos made for #1420 should be in 0.10.1. If you upgrade and still have problems please reopen #1420 and resume discussion there, since this ticket is already closed as a duplicate.

in reply to:  8 comment:9 by Christian Boos, 18 years ago

Replying to mgood:

Replying to theultramage@gmail.com:

For an example changeset, try this one.

You're still running Trac 0.10.

Yes I confirm. I took the diff from this changeset and tried to display it with the patch viewer. It looks a bit weird, as the long lines overlap the page boundaries, but at least everything is visible.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Matthew Good.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Matthew Good to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.