trac-post-commit-hook broken in trunk@HEAD

[exarkun@…]

It passes an integer to Ticket.notify and Ticket.save_changes, but apparently a datetime object is expected now. This blows up.

[exarkun@…]

Here's an ugly patch which seems to fix the problem. The code isn't factored for testability so I didn't write any unit tests.

contrib/trac-post-commit-hook

@@ -72 +72 @@
 import os
 import sys
 import time 
+import datetime
 
 from trac.env import open_environment
 from trac.ticket.notification import TicketNotifyEmail
@@ -79 +80 @@
 from trac.ticket.web_ui import TicketModule
 # TODO: move grouped_changelog_entries to model.py
 from trac.util.text import to_unicode
+from trac.util.datefmt import utc
 from trac.web.href import Href
 
 try:
@@ -141 +143 @@
         self.author = author
         self.rev = rev
         self.msg = "(In [%s]) %s" % (rev, msg)
-        self.now = int(time.time()) 
+        self.now = datetime.datetime.now(utc)
         self.env = open_environment(project)
         if url is None:
             url = self.env.config.get('project', 'url')
@@ -179 +181 @@
                 tn = TicketNotifyEmail(self.env)
                 tn.notify(ticket, newticket=0, modtime=self.now)
             except Exception, e:
-                # import traceback
-                # traceback.print_exc(file=sys.stderr)
+                import traceback
+                traceback.print_exc(file=sys.stderr)
                 print>>sys.stderr, 'Unexpected error while processing ticket ' \
                                    'ID %s: %s' % (tkt_id, e)
             

[Christian Boos]

Well, besides the datetime.datetime that we usually avoid by doing from datetime import datetime, I don't see what is ugly in that patch ;)

[Christian Boos]

This was fixed in r4159.