Error: Macro TicketQuery(...) failed

[ilias@…]

Just updated to the latest version, and got an error.

Reproduction:

within wiki, add this macro call:

fails:

[[TicketQuery(status=assigned|new|reopened&order=type, format=table)]]

works:

[[TicketQuery(status=assigned|new|reopened&order=type)]]

error message:

load_template() takes at most 3 arguments (4 given)

[ilias@…]

caused by a signature change to this method:

def load_template(self, filename, req=None, data=None, method=None):

def load_template(self, filename, method=None):

​http://trac.edgewall.org/changeset/4007/trunk/trac/web/chrome.py

[Christopher Lenz]

Oops, that'd be my fault. This should be fixed in the macro anyway, as passing data to the load_template method seems wrong.

[ilias@…]

yes, it seems wrong. Although the description sounds rational, too:

    def load_template(self, filename, req=None, data=None, method=None):
        """Retrieve a Template and optionally preset the template data.

        If `req` and `data` are given, the `data` dictionary will be preset
        with the "standard" Trac information and helper methods.

        Also, if the optional `method` argument is set to `'text'`, a
        TextTemplate instance will be created instead of a MarkupTemplate.
        """

btw: who will do the change?

Possibly he can apply those patches, too: #3990

[Christopher Lenz]

Fixed in [4009].

[Christian Boos]

… and [4010] helps too ;)

[ilias@…]

It would be nice if a commit subjecting a ticket would just cover that ticket, especially if it was a regression.

r4009

• introduces "fromtimestamp(result.time)" within query.rss
• renames render_response to render_template
• add a parameter to render_template
• exchanges "load_template" by "render_template"

r4010

• introduces signature change to "render_template"
• corrects query.py (Macro TicketQuery)

"Trac" assists to keep development trackable, but of course it depends on the developers discipline, too.

[ilias@…]

btw.: can I 'get' the patches mentioned in #3990 ?