Edgewall Software

Opened 16 years ago

Closed 16 years ago

#3936 closed defect (fixed)

Wiki inconsistently interprets wiki formatting in wiki change comments

Reported by: ben@… Owned by: Christian Boos
Priority: normal Milestone: 0.11
Component: wiki system Version: 0.10
Severity: normal Keywords: formatter context
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:


Make a change to the wiki and use [[PageOutline]] in its change comment. Then observe:

  1. Page History shows [[PageOutline]]
  2. Timeline shows [[PageOutline]]
  3. Page diff shows the page's outline
  4. Timeline RSS feed shows timeline's outline (!)

It would be good to pick one behavior and stick to it.

Attachments (0)

Change History (2)

comment:1 by Christian Boos, 16 years ago

Keywords: formatter context added
Milestone: 0.11
Owner: changed from Jonas Borgström to Christian Boos

Known issue, which can't be solved until a context information is passed to the formatter. The "right" behavior in that case would be to output the outline of the comment itself.

To be able to output the page's outline in the comment text, we probably need to have "stacked" contexts, as suggested by athomas, and a syntax to access to the parent context (e.g. [[PageOutline(..)]]).

comment:2 by Christian Boos, 16 years ago

Resolution: fixed
Status: newclosed

Fixed in r4451.

I should add that I finally didn't do it the way it was suggested in the comment above. The [[PageOutline]] currently operates on the wiki text which is currently being rendered, not one some wiki text (which one?) belonging to the main resource being rendered (the one of the current WikiContext).

This means in this particular case that a [[PageOutline]] in a Wiki comment will give the outline of that comment, when rendered in wiki_to_html mode (e.g. in the Wiki diff view or when viewing that specific version of a Wiki page).

Not terribly useful in this case, but there are many other scenario where this no surprise approach will be useful. Think a big comment in a ticket, a big code review comment later on, etc.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.