Edgewall Software
Modify

Opened 13 years ago

Closed 11 years ago

Last modified 10 years ago

#3899 closed defect (fixed)

Live bookmarks not supported on Custom Query pages

Reported by: leif.s@… Owned by: osimons
Priority: normal Milestone: 0.11.2
Component: ticket system Version: 0.11.1
Severity: minor Keywords:
Cc: matt.nathan@… Branch:
Release Notes:
API Changes:

Description

On most pages Trac supports RSS feeds the way Mozilla Firefox wants them, but it seems this has been forgotten on the Custom Query page.

Attachments (1)

t3899-firefox_feeds-r7529.diff (1.4 KB ) - added by osimons 11 years ago.
Patch to make ticket + custom query feeds work in Firefox (not download).

Download all attachments as: .zip

Change History (9)

in reply to:  description comment:1 by Leif Suonvieri <leif.s@…>, 13 years ago

Replying to leif.s@hem.utfors.se: This also seems to happen on the "ticket view" page…

comment:2 by Matthew Good, 13 years ago

Resolution: worksforme
Status: newclosed

I've tested both on Firefox 2 and they are working correctly.

comment:3 by matt.nathan@…, 11 years ago

Cc: matt.nathan@… added
Resolution: worksforme
Status: closedreopened

I get the same problem. Firefox 3 on both Linux and Mac only offers to download the xml file (query.xml) instead of showing the feed under the custom query page. I also note that it doesn't work for this tickets rss feed.

The RSS for the available reports works as desired as does the timeline.

Tested against 0.11 and this site

comment:4 by osimons, 11 years ago

Component: report systemticket system
Milestone: 0.11.2
Owner: changed from Matthew Good to osimons
Status: reopenednew
Version: 0.100.11.1

You're right. Custom Query and Ticket feeds doesn't work like the others. I'll put it on my to-do.

comment:5 by osimons, 11 years ago

These two feeds do not work as the others as they use mimeview.api.Mimeview.send_converted() to convert and send the feed data. That method does one thing we don't want for feeds: It adds a Content-Disposition header with a constructed filename - forcing Firefox (and possibly other browsers) to see it as a download.

I've made a patch for this behaviour that if passed filename is empty, it does not add this particular header as there is no filename to add - and default filename is 'file' so it should not be empty unless explicitly requested. I don't quite see what far-reaching consequences this may have, but all other downloads seems to work as they should and all tests pass.

Patch follows.

by osimons, 11 years ago

Patch to make ticket + custom query feeds work in Firefox (not download).

comment:6 by Christian Boos, 11 years ago

Tested, works fine.

A detail: maybe using filename=None would be more indicative than filename='' that we don't want to pass a Content-Disposition header?

comment:7 by osimons, 11 years ago

Resolution: fixed
Status: newclosed

Thanks for testing and feedback. Committed with filename=None to 0.11-stable in [7598].

comment:8 by Christian Boos, 10 years ago

But see #7956, we now use None for all alternate formats…

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain osimons.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from osimons to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.