#3899 closed defect (fixed)
Live bookmarks not supported on Custom Query pages
Reported by: | Owned by: | osimons | |
---|---|---|---|
Priority: | normal | Milestone: | 0.11.2 |
Component: | ticket system | Version: | 0.11.1 |
Severity: | minor | Keywords: | |
Cc: | matt.nathan@… | Branch: | |
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
On most pages Trac supports RSS feeds the way Mozilla Firefox wants them, but it seems this has been forgotten on the Custom Query page.
Attachments (1)
Change History (9)
comment:1 by , 18 years ago
comment:2 by , 18 years ago
Resolution: | → worksforme |
---|---|
Status: | new → closed |
I've tested both on Firefox 2 and they are working correctly.
comment:3 by , 16 years ago
Cc: | added |
---|---|
Resolution: | worksforme |
Status: | closed → reopened |
I get the same problem. Firefox 3 on both Linux and Mac only offers to download the xml file (query.xml) instead of showing the feed under the custom query page. I also note that it doesn't work for this tickets rss feed.
The RSS for the available reports works as desired as does the timeline.
Tested against 0.11 and this site
comment:4 by , 16 years ago
Component: | report system → ticket system |
---|---|
Milestone: | → 0.11.2 |
Owner: | changed from | to
Status: | reopened → new |
Version: | 0.10 → 0.11.1 |
You're right. Custom Query and Ticket feeds doesn't work like the others. I'll put it on my to-do.
comment:5 by , 16 years ago
These two feeds do not work as the others as they use mimeview.api.Mimeview.send_converted()
to convert and send the feed data. That method does one thing we don't want for feeds: It adds a Content-Disposition
header with a constructed filename - forcing Firefox (and possibly other browsers) to see it as a download.
I've made a patch for this behaviour that if passed filename
is empty, it does not add this particular header as there is no filename to add - and default filename is 'file'
so it should not be empty unless explicitly requested. I don't quite see what far-reaching consequences this may have, but all other downloads seems to work as they should and all tests pass.
Patch follows.
by , 16 years ago
Attachment: | t3899-firefox_feeds-r7529.diff added |
---|
Patch to make ticket + custom query feeds work in Firefox (not download).
comment:6 by , 16 years ago
Tested, works fine.
A detail: maybe using filename=None
would be more indicative than filename=''
that we don't want to pass a Content-Disposition
header?
comment:7 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Thanks for testing and feedback. Committed with filename=None
to 0.11-stable in [7598].
Replying to leif.s@hem.utfors.se: This also seems to happen on the "ticket view" page…