Edgewall Software
Modify

Opened 21 years ago

Closed 21 years ago

#372 closed defect (fixed)

Main navigation bar is now backward (literally)

Reported by: cmlenz@… Owned by: Christopher Lenz
Priority: normal Milestone: 0.7
Component: general Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Changeset [510] reversed the structural order of the items in the main navigation bar to work around a CSS layout bug in Opera 7 (not sure about older versions, and don't think we should care). The result is that, while the links are visually aranged by CSS-supporting/enabled browsers in the intended order, their order is actually reversed in the underlying markup.

I don't think this change is a good idea (sorry daniel), because:

  1. If you want to customize the layout of a Trac instance without touching the templates themselves, but only by adjusting the style sheets, you have to use a similar layout as the default, or live with the reversed ordering. For example, if I wanted to display the navigation items vertically on the left side of the screen, how would I do that? There's no way, so I'd need to change the template.
  2. Alternative user agents like text browsers and screen readers will also get the reversed order. Assuming that there is some kind of semantic reasoning behind the ordering of the items, this must be considered a bad thing.

I have tried various approaches to fix the original layout problem in Opera, but I don't think there's a safe way. It's unfortunate that Opera 7 is not capable enough to get the rendering right, but still not "dumb" enough to accept any of the known CSS filters/hacks. The only possible solution would be to change the layout, for example by left-aligning the navigation bar.

To summarize, I think this change should be backed out. We shouldn't compromise the quality/flexibility of the markup just because one niche browser doesn't get the rendering right.

Attachments (0)

Change History (4)

comment:1 by cmlenz@…, 21 years ago

Fix for this is included in the patch posted to the mailing list:

http://article.gmane.org/gmane.comp.version-control.subversion.trac.general/236

comment:2 by daniel, 21 years ago

Owner: changed from Jonas Borgström to Christopher Lenz
Status: newassigned

comment:3 by daniel, 21 years ago

Milestone: 0.7.10.7

comment:4 by Christopher Lenz, 21 years ago

Resolution: fixed
Status: assignedclosed

Fixed in [516].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christopher Lenz to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.