Php highlighter loses last line (regression in r3488)

[Tim Hatch <trac@…>]

In certain cases, highlighting using the php binary will chop off the last line after the fix from #3326 (my fault). This should be fixed and tests added so it doesn't happen again, as discussed in ​on trac-dev

I've got a patch for this which needs to be cleaned up a bit before being applied for 0.10 and am attaching that initial patch for reference.

[Tim Hatch <trac@…>]

Second rendition, wrapped to 80 columns, with cboos' Windows fix

[Tim Hatch <trac@…>]

Line 48 still lists a url with p.e.c, missed that when I edited the others. I believe the longest line is 79 characters now, and complies with the spirit of pep8 (is there an automated checker?).

Should the imports for test.locate() be moved module-level?

[Christian Boos]

Replying to Tim Hatch <trac@timhatch.com>:

Line 48 still lists a url with p.e.c,

Will fix it

I believe the longest line is 79 characters now, and complies with the spirit of pep8 (is there an automated checker?).

Maybe pychecker or pylint handle that. A simpler way is to arrange your test editor to have 79 and check that nothnig wraps ;)

Should the imports for test.locate() be moved module-level?

I'll take care of that, too. Thanks for the updated patch!

[Christian Boos]

Applied in r3655 with some minor clean-ups, as suggested by mgood on the trac-dev list.