Modify ↓
Opened 18 years ago
Closed 18 years ago
#3326 closed enhancement (fixed)
Improvements to PHP highlighter
| Reported by: | Owned by: | Christian Boos | |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.10 |
| Component: | general | Version: | devel |
| Severity: | minor | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
Two minor issues with the PHP highlighter (source:trunk/trac/mimeview/php.py):
- The output of
php -snincludes _two_ junk lines at the bottom, although the second one doesn't include the trailing\n. The last line is a</code>that definitely should be stripped. That second-to-last line is a</span>which was messing up validation but apparently not caught because it didn't cause any weirdness. php -snhas this nasty tendency to close tags on the line past where it'd seem logical to close them. This causes a lot of unnecessary html code, and in the interest of sending less data over the wire, this can easily be worked around. I've modified the PHPDeuglifier to scooch the close tags up to where they belong. I'm sad to see this gotcha leave, as it's what let me find #3262.
I've tested both of these points for consistency against PHP 4.3.10-16 on Debian, 4.4.1 on Windows, and 5.1.4-p10 on Gentoo.
Attaching a patch in a sec.
Attachments (2)
Change History (4)
by , 18 years ago
| Attachment: | mimeview-php-spans.diff added |
|---|
by , 18 years ago
| Attachment: | mimeview-php-spans.2.diff added |
|---|
Diff against trunk@3486, fixed line endings
comment:1 by , 18 years ago
| Milestone: | → 0.10 |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
Patch looks fine.
Note:
See TracTickets
for help on using tickets.
Diff against trunk@3483