Edgewall Software
Modify

Opened 13 years ago

Closed 13 years ago

#3325 closed defect (fixed)

trac-post-commit-hook error when both re: and fixes: keywords included

Reported by: mferrier@… Owned by: Christian Boos
Priority: high Milestone: 0.10
Component: ticket system Version: 0.9.5
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description

When a commit message includes both the "re: " and "fixes: " on the same ticket numbers (e.g. "re: #100 fixes: #100"), the trac-post-commit-hook script fails with the following message:

Unexpected error while processing ticket ID 8: columns ticket, time, field are not unique

The script appears to be trying to insert two rows in ticket_change with the same key field values.

Attachments (0)

Change History (9)

comment:1 by Christian Boos, 13 years ago

Milestone: 0.10
Owner: changed from Jonas Borgström to Christian Boos
Priority: lowesthigh
Severity: trivialnormal
Status: newassigned

I tried to have a look at that, and I've seen that a lot of changes I've recently made have horribly broken that script…

comment:2 by Christian Boos, 13 years ago

Resolution: fixed
Status: assignedclosed

Please try out r3486. It works fine for me.

comment:3 by mferrier@…, 13 years ago

Can I use this with my 0.9.5-stable installation?

comment:4 by Christian Boos, 13 years ago

No way. It contains changes that are specific to the 0.10 api/data model. However, it should be possible to downgrade it. I'll have a try.

comment:5 by mferrier@…, 13 years ago

No biggie if you can't, it's not a big deal to just not re: and close: in the same commit message. I'll upgrade to 0.10 when it's stable.

comment:6 by Christian Boos, 13 years ago

He, I guess we had a collision… I was about to say:

I ported the above fix to 0.9-stable in r3487. Can you please test it?

comment:7 by mferrier@…, 13 years ago

Works great, thanks for your help.

comment:8 by anonymous, 13 years ago

Resolution: fixed
Status: closedreopened

comment:9 by Emmanuel Blot, 13 years ago

Resolution: fixed
Status: reopenedclosed

anonymous: do not change the status of a ticket without a reason/description.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.