Edgewall Software
Modify

Opened 16 years ago

Last modified 7 years ago

#3584 new enhancement

[PATCH] Zip file names should match the latest version of their contents, not of the whole repository

Reported by: Emmanuel Blot Owned by:
Priority: normal Milestone: next-major-releases
Component: version control/browser Version: devel
Severity: minor Keywords: patch, zip
Cc: izzysoft@…, Thijs Triemstra Branch:
Release Notes:
API Changes:
Internal Changes:

Description

The original ticket appears as th:ticket:558.

I don't know which solution is the best to implement such a feature (renaming feature as Alec suggested, …), but the current implemention is a real issue on multi-project host servers such as TracHacks.

Attachments (1)

zip_rev.patch (946 bytes ) - added by john.m.camara 14 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 by Alec Thomas, 16 years ago

This patch works, and I've enabled it on TracHacks:

  • trac/versioncontrol/web_ui/changeset.py

     
    228228            req.perm.assert_permission('FILE_VIEW')
    229229            # choosing an appropriate filename
    230230            rpath = new_path.replace('/','_')
    231             if chgset:
     231            if 'filename' in req.args:
     232                filename = req.args['filename']
     233            elif chgset:
    232234                if restricted:
    233235                    filename = 'changeset_%s_r%s' % (rpath, new)
    234236                else:

comment:2 by Christian Boos, 15 years ago

Component: generalbrowser
Milestone: 0.12
Owner: changed from Jonas Borgström to Christian Boos
Priority: lownormal

comment:3 by john.m.camara, 14 years ago

Milestone: 0.120.11

zip_rev.patch sets the rev number based on history instead of the latest rev of the repository.

by john.m.camara, 14 years ago

Attachment: zip_rev.patch added

comment:4 by john.m.camara, 14 years ago

Summary: Zip file names should match the latest version of their contents, not of the whole repository[PATCH] Zip file names should match the latest version of their contents, not of the whole repository

comment:5 by Emmanuel Blot, 14 years ago

Milestone: 0.110.11.1

Not for 0.11.

comment:6 by Emmanuel Blot, 14 years ago

Btw, please do not update the ticket description when you add a patch. Use [PATCH] when submitting a new ticket only, thanks.

comment:7 by osimons, 14 years ago

Keywords: patch added
Owner: changed from Christian Boos to osimons

+1 on the idea. I'll put it on my todo.

comment:8 by osimons, 14 years ago

See also #5119.

comment:9 by izzysoft@…, 14 years ago

Cc: izzysoft@… added

If you are once at the file names:

It would also be nice to be able to specify part of the file name. Finding files named trunk-r123.zip on my disk would drive me crazy ;) I think of a new parameter like "basename", so adding "&basename=something" would result in something-trunk-r123.zip then in the given example.

Next step would be to allow a "default basename" to be defined in your trac.ini, so the pages would render it this way by default.

comment:10 by Christian Boos, 13 years ago

Milestone: 0.11-retriage0.11.6

comment:11 by Christian Boos, 12 years ago

Moved together with #5119.

comment:12 by Christian Boos, 12 years ago

Milestone: next-minor-0.12.xnext-major-0.1X

comment:13 by Thijs Triemstra, 12 years ago

Cc: Thijs Triemstra added
Keywords: zip added

comment:14 by Ryan J Ollos, 7 years ago

Owner: osimons removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.