Edgewall Software
Modify ↓

Opened 19 years ago

Closed 18 years ago

#3540 closed enhancement (fixed)

Option to disable logging in WebAdmin is blank

Reported by: jonka750@… Owned by: Christopher Lenz
Priority: normal Milestone: 0.11
Component: admin/web Version: 0.9.6
Severity: minor Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

To disable logging one has to select a blank alternative. It would be better if the alternative read "none" as in trac.ini.

Attachments (0)

Change History (2)

comment:1 by cmlenz (not logged in), 19 years ago

Milestone: → 0.11

Yeah, I agree.

Patch against r4118:

  • trac/admin/web_ui.py

     
    150150        log_dir = os.path.join(self.env.path, 'log')
    151151
    152152        log_types = [
    153             dict(name='', label=''),
     153            dict(name='', label='none'),
    154154            dict(name='stderr', label='Console', selected=log_type == 'stderr'),
    155155            dict(name='file', label='File', selected=log_type == 'file'),
    156156            dict(name='syslog', label='Syslog', disabled=os.name != 'posix',

comment:2 by osimons <simon-code@…>, 18 years ago

Milestone: 0.11.1 → 0.11
Resolution: → fixed
Status: new → closed

Just checked current 0.11dev (trunk r6044) where webadmin has been integrated, and it now has a 'None' option instead of blank. For such a trivial issue, I do not think it is necessary to dig into the old webadmin plugin to update for older versions.

Closing ticket.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christopher Lenz to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.