[PATCH] When adding custom ticket fields, two fullrow fields may appear on the same row in presentation.

[anonymous]

If an empty ticket filed have to be added in the presentation subsequent fullrow fileds may render on the same row in the HTML.

This patch (for the 0.9-stable branch) will fix the problem:

templates/ticket.cs

@@ -181 +181 @@
   /each ?><?cs set:idx = 0 ?><?cs
    each:field = ticket.fields ?><?cs
     if:!field.skip ?><?cs set:fullrow = field.type == 'textarea' ?><?cs
-     if:fullrow && idx % 2 ?><?cs set:idx = idx + 1 ?><th class="col2"></th><td></td></tr><tr><?cs /if ?>
+     if:fullrow && idx % 2 ?><?cs set:idx = idx + 1 ?>
+     <?cs set:num_fields = num_fields + 1 ?>
+     <th class="col2"></th><td></td></tr><tr><?cs /if ?>
      <th class="col<?cs var:idx % 2 + 1 ?>"><?cs
        if:field.type != 'radio' ?><label for="<?cs var:name(field) ?>"><?cs
        /if ?><?cs alt:field.label ?><?cs var:field.name ?><?cs /alt ?>:<?cs

[Matthew Good]

fix description formatting

[Emmanuel Blot]

I think it would be better to add 'patch' to the keyword list if you want to track patches rather than to change the ticket summary…

[Emmanuel Blot]

(I don't know why the owner has been changed with my last comment)

[sid]

I was following the instructions from this page: TracDev/SubmittingPatches

[Christian Boos]

About the [PATCH] in the summary: I think it's good to indicate this when a ticket is created for the purpose of submitting a patch (as it's the case here). When a patch is added afterwards to an existing ticket, possibly by another author, then I think it's preferable to use the patch keyword than to modify the summary.

As for this specific bug/fix, one should check if that is still relevant for 0.10.

[sid]

This is a duplicate of #3109, and I submitted a more thorough patch (IMO) for that ticket that works for both newticket.cs and ticket.cs. I tried this patch on my system and still had alignment problems (and yep, still happens in 0.10).

Marking as a duplicate.