#3428 closed defect (duplicate)
Trac attempts to diff non-text files
| Reported by: | Owned by: | Christopher Lenz | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | version control | Version: | 0.9.6 |
| Severity: | normal | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
When viewing a changeset, Trac will attempt to perform a diff on any file where none of the first 1000 bytes are the null byte (0x00). This causes the server to hang when viewing a changeset on large (>~16MB) binary files that do not happen to have a null byte in the first 1000 bytes.
Created a patch (trac-mimetype-no-binary-diff.patch) to prevent Trac from attempting to perform a diff on files that have the svn:mime-type property set to something other than "text/*".
Attachments (1)
Change History (5)
by , 19 years ago
| Attachment: | trac-mimetype-no-binary-diff.patch added |
|---|
comment:1 by , 19 years ago
That won't work because some a number of common text formats don't use the text/* super-type. Examples: application/xml and image/svg.
comment:2 by , 19 years ago
See also wiki:TracIniMacro#changeset-section that enables the admin to limit the size of a diff'ed changeset.
comment:3 by , 19 years ago
| Resolution: | → duplicate |
|---|---|
| Status: | new → closed |
This problem is already handled by the patches in #3332.
trac-mimetype-no-binary-diff.patch