Edgewall Software
Modify

Opened 18 years ago

Closed 18 years ago

#3398 closed enhancement (fixed)

Ability to view individual file differences from changeset view

Reported by: Dave Matthews Owned by: Christian Boos
Priority: normal Milestone: 0.11
Component: version control/changeset view Version: devel
Severity: minor Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

It would be nice to be able to easily get to a view of an individual files differences from a normal changeset view. This would make it easy to open the differences from several files in different tabs rather than having to constantly scroll up and down the view. You already get this option if you view a very large changeset, eg http://trac.edgewall.org/changeset?new=%2F%403521&old=%2F%403000. However, if you view a smaller changeset such as http://trac.edgewall.org/changeset/3520/trunk?old=3450&old_path=trunk you don't get this option. Ideally I'd suggest it is added in 2 places.

  1. In the list of files at the top (similar to what you already get with large changesets). You could either change the file link to take you to the individual file differences instead of the file itself or add an additional link.
  2. When viewing the actual differences, eg http://trac.edgewall.org/changeset/3520#file1, the file name currently takes you to the file itself. This is a bit redundant since you can do the same thing by clicking on the link just below ("r3250" in this example). I'd suggest that the file name link takes you to the individual file differences instead.

BTW: Thanks for the new changeset features in 0.10 - they're much appreciated!

Attachments (0)

Change History (5)

comment:1 by Christian Boos, 18 years ago

Severity: normalminor
Version: devel

You can already have something like this by setting the appropriate [changeset] options, e.g.

[changeset]
max_diff_files = 1

I'm not sure if it make sense to have at the same time all the inlined diffs and a quick access to the restricted changesets…

comment:2 by Dave Matthews, 18 years ago

The trouble with this suggestion is that you can then only ever see a single diff. If, for example, I have a changeset with 5 modified files with only 1 or 2 lines modified in each then the inlined diffs are fine. However, if each of those files has several hundred lines changed then it becomes difficult to navigate around the inlined diffs - it would be better to have easy access to to the restricted changesets.

In summary, I definitely don't want to lose the inlined diffs. I just think it would be useful to have easy access to the restricted changesets as well (and I don't see why having both at the same time is a problem, especially when there is a redundant link with the current display).

comment:3 by Christian Boos, 18 years ago

By tweaking the max_diff_files and max_diff_bytes configuration option you can set the appropriate level where you switch from the inlined view to the "summary" view.

For your suggestion 1. (link in the summary), I don't think we should change the file link, as I find the current behavior to be appropriate: clicking on the file link always take you to the latest version of the file, be it an addition, copy, move or a modification (if it's a deletion, it takes you to the last version before the removal). For an additional link, I'm not sure but I have the feeling that it would clutter the interface too much; you could anyway get to the restricted changeset with only an additional click (in the TracBrowser page, the Last Change link).

I'm OK with point 2.

comment:4 by Christian Boos, 18 years ago

Milestone: 0.11
Owner: changed from Jonas Borgström to Christian Boos

(assigning so that I don't forget about this)

comment:5 by Christian Boos, 18 years ago

Resolution: fixed
Status: newclosed

Suggestion 2. implemented in r4682. I'm not in favor of 1., all things considered.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.