Edgewall Software
Modify ↓

Opened 19 years ago

Closed 19 years ago

Last modified 19 years ago

#3258 closed enhancement (fixed)

Attachment spam control (timeline events + listener/change hooks)

Reported by: Alec Thomas Owned by: Jonas Borgström
Priority: normal Milestone: 0.10
Component: general Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

I realise it's late in the game, but if we want the spam control interface in 0.10 to be useful, perhaps we should add attachments to the timeline and an extension point for checking attachments for spam.

Attachment spam is showing up on PEC with alarming frequency and there is no way to detect it. I've attached a patch that adds these features.

Attachments (5)

attachment-spam.diff​ (5.8 KB ) - added by Alec Thomas 19 years ago.
Attachments in timeline + manipulator + listener
attachment-spam.2.diff​ (5.7 KB ) - added by Alec Thomas 19 years ago.
New version with special-cased formatting for wiki and ticket attachments in timeline
attachment.png​ (298 bytes ) - added by Christian Boos 19 years ago.
How about that one?
attachment.2.png​ (257 bytes ) - added by Christian Boos 19 years ago.
How about that one? (greyscaled)
attachment.3.png​ (280 bytes ) - added by markus 19 years ago.
The one I'm using - less dominant

Download all attachments as: .zip

Change History (12)

comment:1 by Alec Thomas, 19 years ago

Milestone: → 0.10
Type: defect → enhancement
Version: 0.9.5 → devel

by Alec Thomas, 19 years ago

Attachment: attachment-spam.diff​ added

Attachments in timeline + manipulator + listener

comment:2 by Alec Thomas, 19 years ago

As this is a duplicate of #3234 and was already targeted for 0.10, I'll commit the manipulator/listener code and leave this open for discussion of the timeline.

Also, need a decent attachment.png for the timeline.

by Alec Thomas, 19 years ago

Attachment: attachment-spam.2.diff​ added

New version with special-cased formatting for wiki and ticket attachments in timeline

by Christian Boos, 19 years ago

Attachment: attachment.png​ added

How about that one?

comment:3 by Christian Boos, 19 years ago

How about that one? ?

by Christian Boos, 19 years ago

Attachment: attachment.2.png​ added

How about that one? (greyscaled)

comment:4 by Alec Thomas, 19 years ago

That is nice :)

I added the manipulator and listener hooks in r3399.

comment:5 by Alec Thomas, 19 years ago

Resolution: → fixed
Status: new → closed

Attachment timeline events added in r3400.

by markus, 19 years ago

Attachment: attachment.3.png​ added

The one I'm using - less dominant

comment:6 by markus, 19 years ago

Though I really like Christian's paper clip icon, I'm using a slightly modified one that is less dominant. I tried to use more or less the same light grey as in wiki.png and changeset.png.

comment:7 by Christian Boos, 19 years ago

You're right, it's better like that. Icon updated in r3427.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.