Edgewall Software
Modify

Opened 16 years ago

Closed 15 years ago

#3168 closed defect (fixed)

No File Upload error from WebAdmin when using install plugin function.

Reported by: skasulka@… Owned by: Christopher Lenz
Priority: normal Milestone: 0.11
Component: admin/web Version: devel
Severity: major Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

In the 'Install Plugin:' part of WebAdmin I try to install a .egg file un the 'File:' field. I hit 'Install' and I get and error 'No file uploaded'. Thanks Shawn

Attachments (2)

plugin_upload.patch (423 bytes ) - added by agraham 15 years ago.
patch to the template file to allow uploads
admin_plugins.html.patch (543 bytes ) - added by Dave Abrahams <dave@…> 15 years ago.
Corresponding patch for 0.11

Download all attachments as: .zip

Change History (8)

comment:1 by Darren Govey, 16 years ago

I'm getting this too when using the TracVM VMWare Appliance to host Apache/Trac/SVN. See the TracVM project page for details.
I'm logged into Linux and Trac as "admin".
I'm using Firefox 1.5.0.6. on Windows XP SP2
The egg I tried to install was TicketDelete-0.1-py2.3.egg, obtained from the "ticketdeleteplugin\0.9\dist" directory of this zip file (after it was extracted locally to my c: drive.

comment:2 by agraham, 15 years ago

Replicated with new install of 0.10rc1 and current SVN build of WebAdmin

comment:3 by agraham, 15 years ago

Version: 0.9.50.10

Got bored and tracked this down. The issue boils down to the plugin being uploaded being referred to by two different variable names. In plugin.py, _do_install checks for the key "plugin_file", while the template form uses the name "egg_file" for the same data. Since _do_install should accept a bare .py file as well as eggs, the template should be modified to use plugin_file.

Changing the names to match resolves the issue for me in an install based on r3772.

by agraham, 15 years ago

Attachment: plugin_upload.patch added

patch to the template file to allow uploads

comment:4 by Christian Boos, 15 years ago

Milestone: 0.11

Seems to apply to 0.11 as well.

by Dave Abrahams <dave@…>, 15 years ago

Attachment: admin_plugins.html.patch added

Corresponding patch for 0.11

comment:5 by Dave Abrahams <dave@…>, 15 years ago

Keywords: 0.10 0.11 added
Version: 0.10devel

It does; I added a corresponding patch.

comment:6 by Christian Boos, 15 years ago

Keywords: 0.10 0.11 removed
Resolution: fixed
Status: newclosed

Patch verified and applied in r5752. Thanks!

While I was at it, I also applied the fix to the WebAdmin plugin for 0.10 (r5753).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christopher Lenz to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.