#3136 closed enhancement (fixed)
Make project prefix in email notifier configurable
| Reported by: | Erik Huelsmann; ehuels at gmail dot com | Owned by: | Jonas Borgström |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.10.1 |
| Component: | ticket system | Version: | devel |
| Severity: | normal | Keywords: | patch |
| Cc: | pacopablo@…, vyt@… | Branch: | |
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
As requested by Emmanuel Slot, I'm filing this issue from a message sent to the development list.
"""I've created the attached patch to disable the project prefix in notification mails because I'm a user of the common-lisp.net site which uses Trac for bug tracking for hosted projects which choose to do so.
All lists get a list prefix prepended by Mailman, so that all tickets lists have a double prefix: both mailman and trac prepend a prefix containing the project name.
If this could be turned off in Trac, there wouldn't be a need to change per-list settings in Mailman, so, I submit this patch hoping it (or a variant) will get committed. """
Attachments (4)
Change History (15)
by , 19 years ago
| Attachment: | ,project-prefix-conf.patch added |
|---|
comment:1 by , 19 years ago
| Cc: | added |
|---|---|
| Owner: | changed from to |
I attached a patch that expands Erik's idea a bit. It allow for the changing of the tag that is used. This means that I can have a subjet tag if the initials of my project, while keeping my project name the full deal. Also, if a '!' is specified, then it has the behavior of Erik's patch in that it doesn't tag the email with anything.
I'll admit that I didn't test the change thoroughly, but I don't think it'll break anything. I decided to use '!' as an indicator of "don't tag" so that the current behavior of "tag with project name" is preserved when a value isn't specified.
comment:2 by , 19 years ago
What about people that are only CCed on one ticket, not subscribed to the mailing list? Now they won't have any project identifier on their notifications.
comment:3 by , 19 years ago
Judgement call.
With these patches, the default behavior is the same as it always has been. If an admin disables subject tagging for a given reason, I think he/she will realize the implications.
comment:4 by , 19 years ago
I'd love to see this patch committed. I run several Trac installations and this has been a problem which would go away with the proposed patch. Thanks.
comment:5 by , 19 years ago
| Owner: | changed from to |
|---|
comment:6 by , 18 years ago
ping!
Can anyone comment on the patch. Can we expect this for 0.10.1? I would love to see this committed also.
by , 18 years ago
| Attachment: | subject_tag_rev2.patch added |
|---|
Updated patch against 0.10 to use None and instead of !
comment:7 by , 18 years ago
| Cc: | added; removed |
|---|
Per suggestion from cboos, modified patch to use None (the default) for indicating that the project name should be used. If no subject tag is desired, then simply set the option to the empty string.
Would love to see this go into 0.10.1 or trunk.
comment:8 by , 18 years ago
| Keywords: | patch added |
|---|---|
| Milestone: | → 0.10.1 |
by , 18 years ago
| Attachment: | subject_tag_rev2.2.patch added |
|---|
Updated patch for 0.10. Fixed obvious logic error
comment:9 by , 18 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I've applied a modified version of the proposed patch in r3994. The main differences are:
- The config option is called smtp_subject_prefix instead of smtp_subject_tag.
- The option value (if supplied) is prepended as-is to the subject. No
[]brackets are added.
comment:11 by , 18 years ago
| Cc: | added |
|---|
smtp_subject_prefix is plain string or it can be dynamic value like current ticket component ? See #1480
The patch