Image Macro fails to render with certain parameters

[jeremy at slappy . org]

Certain macro image formatting options seem to have broken with 0.9.5. To reproduce:

1. Attach an image called picture.jpg to a Wiki page
2. Edit the wiki page to include the following macro:
   • [[Image(picture.jpg, 30%)]]
3. Preview the new wiki page
4. An error message should appear as follows:
   • Error: Macro Image(picture.jpg, 30%) failed
   • Not enough arguments for format string

[jeremy at slappy . org]

A couple more comments:

• These parameters were based on the instructions as specified on WikiMacros
• In the reproduction instructions above, if you change 30% to 120px the Macro works as expected.

[drodrigueztroitino@…]

Patch for ImageMacro with '%' symbol in the attributes.

[drodrigueztroitino@…]

The patch above escape the '%' symbol in the img_attr string so the Markup class don't try to substitute it.

Works for me in a 0.9.5 (Debian version, I think) installation of Trac.

Don't know if the bug rises in other macros, but it should be as simple as this patch to fix them.

[stephane]

I have this problem on Windows too since I installed 0.9.5. I just patched the file and now it works.

Note: I inserted the line

img_attr = img_attr.replace('%', '%%')    # line 355

at line 355 and not at line 346 as shown in the diff (don't know if it's important, only to be precise)

The code now looks like:

    img_attr += ' style="%s"' % img_style # line 354
img_attr = img_attr.replace('%', '%%')    # line 355
result = Markup('<img src="%%s" %s />' % img_attr, raw_url).sanitize()

Conclusion:

• I confirm the existence of this bug
• I would like to see this very small patch in the next version.

Excuse me if I set the version to 0.9.5, and the milestone to 0.10 but it's so a small patch :-)

[Christian Boos]

I'll take care of this one.

[Christian Boos]

Fixed in r3286 and r3287 for 0.9-stable.