Edgewall Software
Modify

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#3007 closed defect (worksforme)

Wrong version of WebAdmin is posted for 0.9.6

Reported by: tom@… Owned by: Jonas Borgström
Priority: normal Milestone:
Component: admin/web Version: 0.9.6
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description (last modified by Christian Boos)

I couldn't find any other place to post this, so I chose this here.

When installing the current version of the TracWebAdmin plugin with trac 0.9.4 the link in the mainnav is broken. I'm attaching a fix which basically converts the yield statement to this:

            yield 'mainnav', 'admin', Markup('<a href="%s">Admin</a>',self.env.href.admin()) 

and adds the import statement for trac.util:

from trac.util import Markup

Attachments (1)

web_ui.py-mainnav-fix.diff (1.3 KB ) - added by tom@… 13 years ago.
Patches weblog_ui.py to use Markup method in mainnav

Download all attachments as: .zip

Change History (6)

by tom@…, 13 years ago

Attachment: web_ui.py-mainnav-fix.diff added

Patches weblog_ui.py to use Markup method in mainnav

comment:1 by Christian Boos, 13 years ago

Description: modified (diff)
Resolution: worksforme
Status: newclosed

Well, you probably don't have the adequate WebAdmin#PluginVersions. The fix you proposed is part of r2705.

comment:2 by tim-edgewall at delete.this.part.bitgems.com, 13 years ago

Resolution: worksforme
Status: closedreopened
Summary: Admin link displayed as HTML-Code in mainnav instead of as clickable linkWrong version of WebAdmin is posted for 0.9.6
Version: 0.9.40.9.6

I just downloaded the r2765 version from http://trac.edgewall.org/wiki/WebAdmin, which is recommended for 0.9.6 (and is a later version than the one listed in this bug as fixed) and it has the same bug. I'd guess that the one zipped up on that page is the one from branches/jonas-dev/webadmin, which is still stuck in a pre-r2705 version, and therefore still has the bug in it. None of the post-branch changes appear in that file in the downloaded version, as far as I can tell.

BTW, I'm using 0.9.6 under Gentoo, which hasn't updated to 0.10 yet.

My workaround will be to grab the r2765 version using Subversion myself, but I wanted to tag this as something you may want to fix on your site.

comment:3 by Christian Boos, 13 years ago

Component: generalwebadmin
Resolution: worksforme
Status: reopenedclosed

Well, the attachement:wiki:WebAdmin:TracWebAdmin-0.1.1dev_r2765-py2.3.egg.zip seems to be OK (contains the Markup('<a href="%s">Admin</a>', ... line).

So probably you're still using an old version, maybe you didn't restart Apache or have some other installation issue.

comment:4 by Christian Boos, 13 years ago

(oops, made a typo in the above, the link is: attachment:wiki:WebAdmin:TracWebAdmin-0.1.1dev_r2765-py2.3.egg.zip)

comment:5 by anonymous, 13 years ago

/ticket/ Powered by Trac 0.9.6 Add/Change

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.