unicode broke arbitrary diffs?

[eli.carter@…]

I can do arbitrary diffs between revisions when using trac trunk revision 3022, but 3029 and 3072 give a python traceback. This error is from 3072:

Python Traceback
Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 306, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 175, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/changeset.py", line 241, in process_request
    diff_args, diff_options)
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/changeset.py", line 459, in _render_html
    for old_node, new_node, kind, change in get_changes():
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/changeset.py", line 352, in get_changes
    for d in repos.get_changes(**diff):
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/svn_fs.py", line 410, in get_changes
    if self.has_node(old_path, old_rev):
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/svn_fs.py", line 262, in has_node
    node_type = fs.check_path(rev_root, self.scope + path, pool())
TypeError: argument number 3: a 'char *' is expected, 'unicode(/trunk/utils/nightly)' is received

[Christian Boos]

Yep, I've noticed too…

[eli.carter@…]

I tried revision 3024; same traceback. So it appears that changeset [3024] broke the arbitrary diff work.

[Christian Boos]

Don't know who closed the ticket, but yes, I believe this now works, thanks to r3090 (use consistently unicode strings on the outside of the versioncontrol.api, use consistently 'utf-8' encoded strings when dealing with the Subversion bindings) and r3092.

[eli.carter@…]

I don't know who closed the ticket either…. and it looks like it was closed before the fix went in. I tried r3090 and r3099; they both seem to work. Thanks for working on it; the arbitrary diff feature is something I'll get a lot of use out of.