Searching for !WikiPageNames keeps the "!" in the highlighted term

[Christian Boos]

I've just noticed a few minor issues when one wants to search for WikiPageNames like terms using the "!" prefix to disable the quickjump facility:

1. The highlighted term will contain the "!" prefix, which usually results in nothing being highlighted.
2. On the opposite, the next pages links don't contain the "!" prefix anymore, resulting in a quickjump when trying to browse subsequent result pages.

Example: search:!TicketQuery (the expected result would be the same as when using search:" TicketQuery").

[Christian Boos]

[2910] fixed point 2.

Point 1. can be fixed by:

trac.js

@@ -41 +41 @@
       var param = params[p].split('=');
       if (param.length < 2) continue;
       if (param[0] == 'q' || param[0] == 'p') { // q= for Google, p= for Yahoo
-        return unescape(param[1].replace(/\+/g, ' ')).split(/\s+/);
+        var searchwords=unescape(param[1]);
+        if (searchwords[0] == '!') searchwords = searchwords.slice(1);
+        return searchwords.replace(/\+/g, ' ').split(/\s+/);
       }
     }
     return [];

As this conflicts with the patches on #2759, I'll postpone this until one of those patches are committed.

[Andres Salomon <dilinger@…>]

highlighting fix against r2944

[Andres Salomon <dilinger@…>]

The patch I just attached is cboos's original patch updated for trunk, now that #2759 has been fixed there.

[Christian Boos]

Thanks for the update. I've checked that in (r2975).