Modify ↓
Opened 19 years ago
Closed 18 years ago
#2609 closed defect (fixed)
/trunk/contrib/trac-pre-commit-hook is unnecessarily case sensitive
| Reported by: | Owned by: | Jonas Borgström | |
|---|---|---|---|
| Priority: | low | Milestone: | 0.11 |
| Component: | general | Version: | 0.9.3 |
| Severity: | trivial | Keywords: | pre-commit-hook |
| Cc: | Robin@…, m@… | Branch: | |
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
The pre-commit hook for SVN is case sensitive and does not support the same command list as the post-commit hook.
Patch to be attached soon.
Attachments (1)
Change History (4)
by , 19 years ago
| Attachment: | trac-pre-commit-hook.case-insensitive.patch added |
|---|
comment:1 by , 19 years ago
| Cc: | added |
|---|
comment:2 by , 18 years ago
| Cc: | added |
|---|
comment:3 by , 18 years ago
| Keywords: | pre-commit-hook added |
|---|---|
| Milestone: | → 0.11 |
| Resolution: | → fixed |
| Status: | new → closed |
Patch applied in r4953.
Note:
See TracTickets
for help on using tickets.
This is my patch for r3566
Index: /opt/trac/contrib/trac-pre-commit-hook =================================================================== --- /opt/trac/contrib/trac-pre-commit-hook (Revision 3566) +++ /opt/trac/contrib/trac-pre-commit-hook (Arbeitskopie) @@ -30,8 +30,8 @@ log = sys.argv[2] tickets = [] - for tmp in re.findall('(?:closes|fixes|addresses|references|refs|re)' - '.?(#[0-9]+(?:(?:[, &]+| *and *)#[0-9]+)*)', log): + for tmp in re.findall('(?:close|closed|closes|fix|fixed|fixes|addresses|references|refs|re|see)' + '.?(#[0-9]+(?:(?:[, &]+| *and *)#[0-9]+)*)', log.lower()): tickets += re.findall('#([0-9]+)', tmp) # At least one ticket has to be mentioned in the log message