Edgewall Software

Opened 16 years ago

Closed 15 years ago

#2609 closed defect (fixed)

/trunk/contrib/trac-pre-commit-hook is unnecessarily case sensitive

Reported by: Robin@… Owned by: Jonas Borgström
Priority: low Milestone: 0.11
Component: general Version: 0.9.3
Severity: trivial Keywords: pre-commit-hook
Cc: Robin@…, m@… Branch:
Release Notes:
API Changes:
Internal Changes:


The pre-commit hook for SVN is case sensitive and does not support the same command list as the post-commit hook.

Patch to be attached soon.

Attachments (1)

trac-pre-commit-hook.case-insensitive.patch (956 bytes ) - added by Robin@… 16 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 by Robin <Robin@…>, 16 years ago

Cc: Robin@… added

comment:2 by Markus Tacker <m@…>, 16 years ago

Cc: m@… added

This is my patch for r3566

Index: /opt/trac/contrib/trac-pre-commit-hook
--- /opt/trac/contrib/trac-pre-commit-hook      (Revision 3566)
+++ /opt/trac/contrib/trac-pre-commit-hook      (Arbeitskopie)
@@ -30,8 +30,8 @@
     log = sys.argv[2]

     tickets = []
-    for tmp in re.findall('(?:closes|fixes|addresses|references|refs|re)'
-                          '.?(#[0-9]+(?:(?:[, &]+| *and *)#[0-9]+)*)', log):
+    for tmp in re.findall('(?:close|closed|closes|fix|fixed|fixes|addresses|references|refs|re|see)'
+                          '.?(#[0-9]+(?:(?:[, &]+| *and *)#[0-9]+)*)', log.lower()):
         tickets += re.findall('#([0-9]+)', tmp)

     # At least one ticket has to be mentioned in the log message

comment:3 by Christian Boos, 15 years ago

Keywords: pre-commit-hook added
Milestone: 0.11
Resolution: fixed
Status: newclosed

Patch applied in r4953.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.