Edgewall Software
Modify

Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#2545 closed enhancement (fixed)

Browser should show SVN revision properties

Reported by: Emmanuel Blot Owned by: Christian Boos
Priority: low Milestone: 0.11
Component: version control/changeset view Version: devel
Severity: minor Keywords: properties
Cc: thomas.tressieres@… Branch:
Release Notes:
API Changes:

Description

Note: This RFE refers to Trac with SVN back-end, but could also be applied to other backend, such as Mercurial back-end.

Trac browser shows file-based properties (for example, svn:ignore).

However, it ignores revision-based properties.
It would be nice if Trac were able to show this kind of properties as well.

Attachments (1)

svn_chgset_get_properties_r3116.diff (1.9 KB ) - added by Christian Boos 14 years ago.
Initial implementation of the feature

Download all attachments as: .zip

Change History (13)

comment:1 by Christian Boos, 14 years ago

Milestone: 1.0
Owner: changed from Jonas Borgström to Christian Boos
Status: newassigned

Are you sure you want to see those properties in the TracBrowser, not in the TracChangeset view?

comment:2 by Emmanuel Blot, 14 years ago

Component: browserchangeset view

You're right, it makes (more) sense to have it in the TracChangeset view.

by Christian Boos, 14 years ago

Initial implementation of the feature

comment:3 by Christian Boos, 14 years ago

Keywords: properties added
Milestone: 1.00.11

I've uploaded an initial implementation for this. What remains to be done, is a way to associate a plaintext flag as well as an htmlclass (one of time, author, message or changeset) to the property (see the API).

Or perhaps reuse some of the forthcoming mechanisms for rendering node properties (see #1601).

comment:4 by ttressieres, 13 years ago

Cc: thomas.tressieres@… added

do you think the patch could be applied in 0.10.1 or 0.11 Trac version ? I need it to implement the feature in http://trac-hacks.org/ticket/628.

in reply to:  4 comment:5 by Matthew Good, 13 years ago

Replying to ttressieres:

do you think the patch could be applied in 0.10.1 or 0.11 Trac version

This is scheduled for 0.11. Upcoming 0.10.x releases will only contain bugfixes.

comment:6 by Christian Boos, 13 years ago

Yes, I'll commit the patch (for 0.11) but be prepared for possible interface change once #1601 progresses…

in reply to:  6 comment:7 by ttressieres, 13 years ago

Replying to cboos:

Yes, I'll commit the patch (for 0.11) but be prepared for possible interface change once #1601 progresses…

Yes, i saw this ticket too, i'll be prepared… thank you.

comment:8 by Christian Boos, 13 years ago

Resolution: fixed
Status: assignedclosed

Patch updated and applied in r4130.

comment:9 by Christian Boos, 13 years ago

As advertised, the revision properties are now rendered using the IPropertyRenderer from #1601.

Please take a look at the source:sandbox/property-renderers-tmp@4530 (see Last Change from there); I'd be interested in eventually getting some feedback before integrating that work branch in trunk.

comment:10 by Emmanuel Blot, 13 years ago

I just gave a try. It seems to work fine w/ my custom properties. Thanks!

As a small enhancement, I think the custom properties should be more visible, or at least differenciated from the regular SVN properties. Maybe a different color/style (CSS), and all custom properties grouped as they are now, but separated from the regular properties with a blank line or the like.

I'm thinking about another enhancement - that could be done through another ticket though: it would be nice if it was possible to define a property-to-name mapping in trac.ini. For example, svn:log is shown as Message, svn:author as Author. It would be great to define custom property names in the config file, such as in the following example

[svnprops]
my:version = Version

comment:11 by Christian Boos, 13 years ago

See also r4618, which introduces the possibility to have even more control over the rendered property, by returning a RenderedProperty instance instance of just text or markup - which is still possible, of course. This is especially useful for changeset properties.

comment:12 by Christian Boos, 13 years ago

Support for RenderedProperty (in addition to plain text and Markup return values) merged in trunk in r4655.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.