Python exception on malformed wiki URL

[molle.bestefich@…]

Go to this URL:

​http://projects.edgewall.com/trac/attachment/wiki/TracMercurial/

And you'll get this:

Traceback (most recent call last):
  File "/usr/lib/python2.3/site-packages/trac/web/modpython_frontend.py", line 206, in handler
    dispatch_request(mpr.path_info, mpr, env)
  File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 139, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 107, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/lib/python2.3/site-packages/trac/attachment.py", line 273, in process_request
    self._render_view(req, attachment)
  File "/usr/lib/python2.3/site-packages/trac/attachment.py", line 390, in _render_view
    req.check_modified(attachment.time)
  File "/usr/lib/python2.3/site-packages/trac/web/api.py", line 103, in check_modified
    etag = 'W"%s/%d/%s"' % (self.authname, timesecs, extra)
TypeError: int argument required

Where you really would have expected:

An HTTP 404 response and a fancy 'not found' page for the user to look at :-).

[Christian Boos]

Fortunately this has nothing to do with TracMercurial :) You get this for any attachment/*/*/ URL…

Let's see… ok. I fixed it, but have no connectivity to svn.edgewall.com right now…

[Christian Boos]

Fixed in r2656 and r2659.