Edgewall Software
Modify

Opened 19 years ago

Closed 18 years ago

#2444 closed defect (fixed)

Trac accessibility shortcuts conflict with tab switching in Firefox

Reported by: marius@… Owned by: Jonas Borgström
Priority: normal Milestone: 0.11
Component: version control/browser Version: devel
Severity: minor Keywords:
Cc: manuzhai@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Firefox on Linux uses Alt-1…Alt-9 to switch between tabs. Trac registers various Alt-numbers as accesskeys for various pages in the navbar. If I press Alt-#, both actions take place: Firefox focuses another tab and activates a link in the old tab. It is very irritating.

I want to disable these accesskeys, but they are hardcoded in Python code.

Attachments (2)

no-num-accesskeys.diff (450 bytes ) - added by Manuzhai 18 years ago.
Disable numeric accesskeys.
no-num-accesskeys.2.diff (2.5 KB ) - added by Manuzhai 18 years ago.
New patch.

Download all attachments as: .zip

Change History (9)

comment:1 by Manuzhai, 19 years ago

Cc: manuzhai@… added

Me too, but for a different reason: I frequently use ALT + 130 like codes for special characters, and these accesskeys break that. There should be an easy way to disable them.

comment:2 by anonymous, 18 years ago

I am experiencing this problem too. The bug is quite annoying because it is usually triggered in this scenario:

  1. Open some bug report in Trac
  2. Switch to another tab using Alt+2
  3. Firefox switches to the tab, meanwhile Trac loads another page instead of the bug report. Because it happens in the background, the reload is very noticeable.
  4. Try to switch back to bug report, but it's gone! Scour through other tabs to no avail, resort to finding the page you were on again. Of course, you could click "Back" if you were aware of the bug, but as I said it's not very noticeable.

comment:3 by airbaggins@…, 18 years ago

Version: 0.9.1devel

I would like to register my dissatisfaction for these accesskeys too. I experience the same things with the firefox tab switching. It is very frustrating if you have entered a long bug report

comment:4 by marijn, 18 years ago

Me too, basically. After losing two meticulously typed out feature requests because my webmail in another firefox tab announced a new mail, and my first reaction was to hit alt-2 to go there, only to find my trac tab back at the timeline page and my text gone (back-button didn't recover it, for some reason).

comment:5 by Manuzhai, 18 years ago

I'm not sure if there is a quick fix for this while retaining the functionality, but for those who find this annoying enough to want to apply a patch, I've attached a two-line patch that disables all numeric accesskeys generated from the code.

by Manuzhai, 18 years ago

Attachment: no-num-accesskeys.diff added

Disable numeric accesskeys.

by Manuzhai, 18 years ago

Attachment: no-num-accesskeys.2.diff added

New patch.

comment:6 by Manuzhai, 18 years ago

I just added a new patch. The older patch doesn't work on 0.11dev, since the place where it filtered out the accesskeys moved to Genshi.

This patch is also cleaner in the sense that it just cuts out the originating code.

comment:7 by Christopher Lenz, 18 years ago

Milestone: 0.11
Resolution: fixed
Status: newclosed

Accesskeys need to be explicitly enabled on the users settings page since [4024].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.