make trac-post-commit-hook also set the owner to the commiter

[Pedro Algarvio <ufs@…>]

trac-post-commit-hook could also set the owner of the ticket prior to closing it to the user commiting.

./trac-post-commit-hook

@@ -151 +151 @@
         for tkt_id in tickets:
             try:
                 ticket = Ticket(self.env, tkt_id)
+               ticket['owner'] = self.author   # Set ticket ownership to commiter
                 ticket['status'] = 'closed'
                 ticket['resolution'] = 'fixed'
                 ticket.save_changes(self.author, self.msg, self.now)

[osimons]

Replying to Pedro Algarvio <ufs@ufsoft.org>:

trac-post-commit-hook could also set the owner of the ticket prior to closing it to the user commiting.

It could, but should it? A nice clean-cut decision ticket, finally :-) Line into the script or not?

As this has stayed open with no registered duplicates or other known demands for this feature, I suppose someone has to speak up in favour of it, or else we might as well close it as 'wontfix'.

Cast your votes, people!

[Kamil Kisiel <kamil@…>]

This patch makes no sense. IMO the "owner" of a ticket is the person responsible for overseeing its progress, and not necessarily the person who is doing commits that reference it.

Imagine if you have 4 or 5 people making commits that reference the same ticket, the owner field would be jumping all over the place.

[Mike Stoddart <stodge@…>]

Replying to Kamil Kisiel <kamil@…>:

This patch makes no sense. IMO the "owner" of a ticket is the person responsible for overseeing its progress, and not necessarily the person who is doing commits that reference it.

Imagine if you have 4 or 5 people making commits that reference the same ticket, the owner field would be jumping all over the place.

I agree, it makes no sense. Ownership should not be related to who commits a change. In our environment, I expect only one person to commit changes for each ticket. A ticket's ownership should only change via the browser interface.

[Pedro Algarvio, aka, s0undt3ch]

My initial idea was if the ticket had no owner.

[Christian Boos]

Replying to palgarvio:

My initial idea was if the ticket had no owner.

… then please update the patch accordingly ;-)

[Christian Boos]

This will eventually have to be updated w.r.t. the new CommitTicketUpdatePlugin (see r8094).

[Remy Blank]

Oh, that's easy enough (setting the owner, but only if no owner was set before). I can do that.

[Remy Blank]

With [8398], the owner field is set to the committer when the plugin closes a ticket, and the owner field was empty.