Edgewall Software
Modify

Opened 14 years ago

Closed 10 years ago

#2325 closed enhancement (fixed)

make trac-post-commit-hook also set the owner to the commiter

Reported by: Pedro Algarvio <ufs@…> Owned by: Remy Blank
Priority: normal Milestone: 0.12
Component: general Version: 0.9
Severity: trivial Keywords: CommitTicketUpdate
Cc: ufs@… Branch:
Release Notes:
API Changes:

Description

trac-post-commit-hook could also set the owner of the ticket prior to closing it to the user commiting.

  • ./trac-post-commit-hook

    old new  
    151151        for tkt_id in tickets:
    152152            try:
    153153                ticket = Ticket(self.env, tkt_id)
     154               ticket['owner'] = self.author   # Set ticket ownership to commiter
    154155                ticket['status'] = 'closed'
    155156                ticket['resolution'] = 'fixed'
    156157                ticket.save_changes(self.author, self.msg, self.now)

Attachments (0)

Change History (11)

comment:1 by Pedro Algarvio <ufs@…>, 14 years ago

Type: defectenhancement

comment:2 by Pedro Algarvio <ufs@…>, 14 years ago

Cc: ufs@… added

comment:3 by Pedro Algarvio, aka, s0undt3ch <ufs@…>, 13 years ago

Milestone: 0.11

in reply to:  description comment:4 by osimons, 12 years ago

Replying to Pedro Algarvio <ufs@ufsoft.org>:

trac-post-commit-hook could also set the owner of the ticket prior to closing it to the user commiting.

It could, but should it? A nice clean-cut decision ticket, finally :-) Line into the script or not?

As this has stayed open with no registered duplicates or other known demands for this feature, I suppose someone has to speak up in favour of it, or else we might as well close it as 'wontfix'.

Cast your votes, people!

comment:5 by Kamil Kisiel <kamil@…>, 11 years ago

This patch makes no sense. IMO the "owner" of a ticket is the person responsible for overseeing its progress, and not necessarily the person who is doing commits that reference it.

Imagine if you have 4 or 5 people making commits that reference the same ticket, the owner field would be jumping all over the place.

in reply to:  5 comment:6 by Mike Stoddart <stodge@…>, 11 years ago

Replying to Kamil Kisiel <kamil@…>:

This patch makes no sense. IMO the "owner" of a ticket is the person responsible for overseeing its progress, and not necessarily the person who is doing commits that reference it.

Imagine if you have 4 or 5 people making commits that reference the same ticket, the owner field would be jumping all over the place.

I agree, it makes no sense. Ownership should not be related to who commits a change. In our environment, I expect only one person to commit changes for each ticket. A ticket's ownership should only change via the browser interface.

comment:7 by Pedro Algarvio, aka, s0undt3ch, 11 years ago

My initial idea was if the ticket had no owner.

in reply to:  7 comment:8 by Christian Boos, 11 years ago

Milestone: 0.11-retriage0.12

Replying to palgarvio:

My initial idea was if the ticket had no owner.

… then please update the patch accordingly ;-)

comment:9 by Christian Boos, 10 years ago

Keywords: CommitTicketUpdate added
Milestone: 0.120.13

This will eventually have to be updated w.r.t. the new CommitTicketUpdatePlugin (see r8094).

comment:10 by Remy Blank, 10 years ago

Milestone: 0.130.12
Owner: changed from Jonas Borgström to Remy Blank

Oh, that's easy enough (setting the owner, but only if no owner was set before). I can do that.

comment:11 by Remy Blank, 10 years ago

Resolution: fixed
Status: newclosed

With [8398], the owner field is set to the committer when the plugin closes a ticket, and the owner field was empty.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Remy Blank.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Remy Blank to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.