query string values are ignored during search

[mgsmith@…]

When performing a seach, the values of the query string are ignored, only their existence is tested.

For example, these two search should both search just the tickets:

• ​http://projects.edgewall.com/trac/search?q=email&wiki=off&changeset=off&ticket=on
• ​http://projects.edgewall.com/trac/search?q=emailticket=on

…but the first one search tickets, wiki, and changesets.

---

Here is a patch to C:\Python23\Lib\site-packages\trac\Seach.py (around line 200)…

• before:

          if self.args.has_key('q'):
              query = self.args.get('q')
              self.req.hdf.setValue('title', 'Search Results')
              self.req.hdf.setValue('search.q', query.replace('"', """))
              tickets = self.args.has_key('ticket')
              changesets = self.args.has_key('changeset')
              wiki = self.args.has_key('wiki')
  

• after:

          if self.args.has_key('q'):
              query = self.args.get('q')
              self.req.hdf.setValue('title', 'Search Results')
              self.req.hdf.setValue('search.q', query.replace('"', """))
              tickets = self.args.get('ticket') == "on"
              changesets = self.args.get('changeset') == "on"
              wiki = self.args.get('wiki') == "on"
  

[Bruce Christensen <trac@…>]

The fields that you are talking about are submitted via a checkbox on an HTML form. The ​HTML 4.0 forms spec states:

Checkboxes (and radio buttons) are on/off switches that may be toggled by the user. A switch is "on" when the control element's checked attribute is set. When a form is submitted, only "on" checkbox controls can become successful.

So at least as far at HTML forms are concerned, a value of off should never be sent.

[Christopher Lenz]

This works as intended. To exclude results of certain kinds, the parameter should be removed from the query string.