Edgewall Software
Modify

Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#2318 closed defect (fixed)

Inconsistent display for Subversion move and copy

Reported by: Matt Shin Owned by: Christian Boos
Priority: normal Milestone: 0.9.1
Component: version control/changeset view Version: 0.9
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description

The Trac changeset view appears inconsistent following a restructure of our Subversion repository. I can demonstrate the problem by restructuring the following mini-directory structure:

test1/b
test1/d
test2/b
test2/d
test3/b
test3/d

Create a new directory "test1/a", and move "test1/b" and "test1/d" to it:

svn mkdir test1/a
svn mv test1/b test1/a
svn mv test1/d test1/a

Create a new directory "test2/c" and move "test2/b" and "test2/d" to it:

svn mkdir test2/c
svn mv test2/b test2/c
svn mv test2/d test2/c

Create a new directory "test3/e" and move "test3/b" and "test3/d" to it:

svn mkdir test3/e
svn mv test3/b test3/e
svn mv test3/d test3/e

The changeset view displays the moves as follow:

(Added)   test1/a
(Moved)   test1/a/b (moved from test1/b)
(Removed) test1/b
(Added)   test2/c
(Moved)   test2/c/b (moved from test2/b)
(Moved)   test2/c/d (moved from test2/d)
(Removed) test3/b
(Removed) test3/d
(Moved)   test3/e/b (moved from test3/b)

While the operations on "test1", "test2" and "test3" are identical, alphabetical order appears to have some effect on what is displayed? (Clearly, the displays for "test1" and "test3" are both wrong.)

Attachments (1)

svn_fs-copyrename-test.patch (8.3 KB ) - added by Christian Boos 14 years ago.
Patch against r2520 adding a test case following this ticket's description

Download all attachments as: .zip

Change History (5)

comment:1 by Christian Boos, 14 years ago

Milestone: 0.9.1
Owner: changed from Jonas Borgström to Christian Boos
Status: newassigned

Reproduced and understood…

comment:2 by Christian Boos, 14 years ago

Resolution: fixed
Status: assignedclosed

Fixed in r2520 and r2521.

I've also made a new test suite (with a new repo) for that, but while useful for debugging the issue, I'm not sure it's worth checking all that in…

comment:3 by Christopher Lenz, 14 years ago

cboos, in case you haven't thrown the test case away yet, how about attaching it as a patch here? Would be nice to get a regression test for this in, although it should of course be minimal.

by Christian Boos, 14 years ago

Patch against r2520 adding a test case following this ticket's description

comment:4 by Christian Boos, 14 years ago

Yep, patch with the test attached.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.