Opened 19 years ago
Closed 19 years ago
#2238 closed defect (fixed)
Confusing Error message issued when mime gateway is nonresponsive.
Reported by: | Owned by: | Jonas Borgström | |
---|---|---|---|
Priority: | normal | Milestone: | 0.9 |
Component: | ticket system | Version: | 0.8.4 |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
When TRAC tries to send email notification of activity and the designated mime gateway is unresponsive, TRAC returns the a stack trace.
A more informative error message would be more helpful. A log of the SMTP dialog would be even better.
Python traceback
Traceback (most recent call last):
File "D:\www\python\Lib\site-packages\trac\ModPythonHandler.py", line 195, in handler
core.dispatch_request(mpr.path_info, args, mpr, env)
File "D:\www\python\lib\site-packages\trac\core.py", line 441, in dispatch_request
module.run()
File "D:\www\python\Lib\site-packages\trac\Module.py", line 44, in run
self.render()
File "D:\www\python\lib\site-packages\trac\Ticket.py", line 474, in render
self.save_changes (id)
File "D:\www\python\lib\site-packages\trac\Ticket.py", line 391, in save_changes
tn.notify(ticket, newticket=0, modtime=now)
File "D:\www\python\lib\site-packages\trac\Notify.py", line 229, in notify
NotifyEmail.notify(self, ticketid, subject)
File "D:\www\python\lib\site-packages\trac\Notify.py", line 132, in notify
Notify.notify(self, resid)
File "D:\www\python\lib\site-packages\trac\Notify.py", line 79, in notify
self.begin_send()
File "D:\www\python\lib\site-packages\trac\Notify.py", line 140, in begin_send
self.server = smtplib.SMTP(self.smtp_server)
File "D:\www\python\lib\smtplib.py", line 240, in init
(code, msg) = self.connect(host, port)
File "D:\www\python\lib\smtplib.py", line 302, in connect
raise socket.error, msg
error: (10060, 'Operation timed out')
Attachments (0)
Change History (1)
comment:1 by , 19 years ago
Milestone: | → 0.9 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
AFAICT, SMTP notification failures are now catched (in 0.9) and no Python trace is returned to the user. The error is nevertheless dumped to the logger.
The SMTP dialog with the SMTP server is handled by the Python smtp library, which makes it hard to retrieve.