WebAdmin plugin enabling is reversed

[Pedro Algarvio <ufs@…>]

I found no other place to submit a but for the WebAdmin plugin, so I've submited it here, hopefully on the right place, I just think there should be a "component" for it.

Well, here's my prob, when trying to disable a trac feature with webadmin, namely trac.milestone.milestonemodule and trac.roadmap.roadmapmodule, here's what happens on the env's trac.ini:

[components]
trac.milestone.milestonemodule = enabled
trac.roadmap.roadmapmodule = enabled

when it should be:

[components]
trac.milestone.milestonemodule = disabled
trac.roadmap.roadmapmodule = disabled

So I guess the default behaviour when disabling "parts" with the WebAdmin plugin is wrong. No matter how many times I try to disable a "part/feature" it always writes enabled on trac.ini, and I always have to edit it by hand to change the value.

Hum, and to try the oposite, enable a disabled component, the most awkward thing happened. I enabled trac.milestone.milestonemodule, and here's what happened on trac.ini:

[components]
trac.milestone.milestonemodule = disabled
trac.roadmap.roadmapmodule = enabled

My trac is on revision is 2344 and the webmin is on 2340, the most current for today, 11/out/2005.

[Matthew Good]

The behavior here is reversed, since the variable is_enabled reflects whether the component is currently enabled, so the setting should be flipped:

webadmin/plugin.py

@@ -136 +136 @@
         for component in components:
             is_enabled = self.env.is_component_enabled(component)
             if is_enabled != (component in enabled):
-                if is_enabled:
-                    self.config.set('components', component, 'enabled')
-                else:
-                    self.config.set('components', component, 'disabled')
+                self.config.set('components', component, is_enabled and \
+                        'disabled' or 'enabled')
                 self.log.info('%sabling component %s',
                               is_enabled and 'Dis' or 'En', component)
                 changes = True

[Christopher Lenz]

Fixed in [2348].