identify the mimetype

[Otavio Salvador]

Would be great if trac identify the mime type also by reading the file header.

For example, debian/rules files has it's first line set to #!/usr/bin/make -f and is safe to use Makefile highlight for it. This apply too to shell scripts and others.

Thanks in advance,

[Christian Boos]

Additional requirement: support Emacs mode specification, e.g.

# This is a -*- Makefile -*- 

foo: bar
       cp bar foo

[Christian Boos]

Implementation of the feature, which required a bit of refactoring (mainly, get the content first, before it can be passed on to Mimeview.get_mimetype())

[Christian Boos]

The above refactoring is a kind of follow-up to r2276: less duplicated mimeview related code in attachment.py, browser.py and now changeset.py, and put the common code in mimeview/api.py.

Not necessarily for 0.9, as it's just an enhancement.

[Christian Boos]

In the previous comment, by the above refactoring, I was referring to the attachment:mimeview-refactoring.patch​

That was not clear in the Trac-Ticket notification mail, since it displayed also my formatting change in the description…

[Matthew Good]

Cboos before you start trying to build a mime inspection method into Trac there is already a Python module made to work similarly to the Unix "file" command: ​http://www.demonseed.net/~jp/code/magic.py

Unfortunately the file has a copyright statement, but no licensing terms, so I'm contacting the author to try to get an acceptable license for it.

There is another similar module listed in the Cheese Shop, but it's licensed under the GPL, so it's not usable for Trac now: ​http://www.python.org/pypi/pymagic/0.1

I know it's also possible to inspect mime types through the Python bindings to the Gnome libraries, which is not as portable, but could be used in combination with the magic module mentioned above.

I'll let you know what I hear about licencing on that module.

[Christian Boos]

The above patch is not doing a mime inspection of the file, it only takes into account the shebang or the Emacs mode. But the refactoring done at that occasion would be benefitial to any other, more complex, auto-detection method.

[Christian Boos]

Refactoring of the way the mimetype is associated to the file: This is now done after the content (or the first chunk of it) is seen, enabling all sorts of detection schemes (a simple shebang detection is done for now, more can be added later, why not in a "pluggable" way)

[Christian Boos]

Updated version of the patch added (attachment:mime-inspect-r2500.patch)

Please review.

[Christian Boos]

The attachment's link was actually attachment:mimeview-inspect-r2500.patch​

[Christian Boos]

Patch applied in r2653.