Invalid clearsilver HDF objects

[sean.dawson@…]

I've managed to find some errors with the way the hdf tree is populated.

Problem 1: Some of the keys have spaces in them (this is incorrect) Problem 2: Some of the keys have both a value and a dictionary of children. For example, when you render the chrome.nav.mainnav segment, you have entries like:

chrome {
   nav {
     mainnav {
         wiki = /some/path {
            active = 1
         }
     }
   }
}

This doesn't make much sense; a key shouldn't have two conceptual values. On a more practical note, clearsilver can not load a datastructure in this format. I am writing a client that talks to trac via the hdf dump, and this is a very big problem for me.

​Here is a patch for the latest trunk (2067). I am not sure if I caught all the errors: perhaps an "assertion" check in the setitem method in the clearsilver.py module to prevent any further corruption.

Thanks, Sean

[Christopher Lenz]

The report module unfortunately makes heavy use of this feature. So I don't think we'll be able to fix all occurences of this for 0.9. The instances outside of the report module could be fixed, though.

[Matthew Good]

This doesn't seem to hurt functionality, so this isn't going to make it in for 0.10 and 0.11 will no longer use ClearSilver, so there's no point in keeping this open.