Edgewall Software
Modify

Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#1895 closed defect (fixed)

Make it easier to disable ticket details timeline events

Reported by: Jonas Borgström Owned by: Christian Boos
Priority: high Milestone: 0.10
Component: ticket system Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description

  • It's not intuitive to have to disable a specific component to disable a feature.
  • This also makes it harder to refactor the code in the future without breaking compatibility.
  • This feature should also probaably be disabled by default.

Attachments (2)

ticket_details_off_by_default.patch (2.4 KB ) - added by Christian Boos 14 years ago.
Enable timeline event provider to specify the default status of the filters (e.g. UpdateDetailsForTimeline is off by default)
merged-ticket-event-provider.patch (10.4 KB ) - added by Christian Boos 14 years ago.
Integrated the UpdateDetailsForTimeline functionality within the Ticket's event provider. The code is much simpler and hopefully cleaner now. Patch made on source:trunk@2500.

Download all attachments as: .zip

Change History (12)

comment:1 by Christopher Lenz, 14 years ago

Also, the difference between "Ticket changes" and "Ticket details" in the timeline options box is totally non-obvious. If showing every ticket change in the timeline is enabled through a config option, there should be no additional checkbox in the timeline options IMHO.

comment:2 by Christian Boos, 14 years ago

It's not intuitive to have to disable a specific component to disable a feature. This also makes it harder to refactor the code in the future without breaking compatibility.

Couldn't that be said for any component put in the [disabled_components] section?

Also, the difference between "Ticket changes" and "Ticket details" in the timeline options would be more obvious if instead of two checkboxes we had a Ticket changes combobox with the values None, Only status changes and All options.

I agree that being able to request the Ticket details without also having the Ticket changes selected doesn't make much sense.

But having the switch in the TracIni only is a bit restrictive: some users would like to have an overview, others would like more details… it all depends on the level of involvement of the user to the project. Trac's Trac can easily be configured without that feature, because people interested in all ticket changes can always subscribe to the Trac-Tickets mailing list, but for other projects it is certainly interesting to have that information directly available from Trac.

comment:3 by Christian Boos, 14 years ago

Owner: changed from Jonas Borgström to Christian Boos
Priority: normalhigh

I'll make a patch which will make that filter checked off by default.

by Christian Boos, 14 years ago

Enable timeline event provider to specify the default status of the filters (e.g. UpdateDetailsForTimeline is off by default)

comment:4 by Christian Boos, 14 years ago

Status: newassigned

The attachment:ticket_details_off_by_default.patch doesn't try to merge the UpdateDetailsForTimeline timeline event provider with the Ticket timeline event provider: it's afterall not that natural, the patch I came up with seems to "force" things too much. So I don't think it's worth it.

Also, if they are brought together, it becomes impossible to disable the feature completely.

comment:5 by Christian Boos, 14 years ago

Milestone: 0.90.9.1

Patch applied in [2378].

A new TracIni configuration option has been added as well, to disable the feature completely.

As for the merge of the UpdateDetailsForTimeline component in the TicketModule timeline event provider, I'll do it later (0.9.1).

by Christian Boos, 14 years ago

Integrated the UpdateDetailsForTimeline functionality within the Ticket's event provider. The code is much simpler and hopefully cleaner now. Patch made on source:trunk@2500.

comment:6 by Christian Boos, 14 years ago

There's now a patch (attachment:merged-ticket-event-provider.patch) which merge both ticket event providers into one.

I'm quite satisfied with the result, but nevertheless please review.

comment:7 by Christian Boos, 14 years ago

Keywords: review added

comment:8 by Christopher Lenz, 14 years ago

Milestone: 0.9.10.9.2

comment:9 by Christian Boos, 14 years ago

Keywords: review removed
Milestone: 0.9.31.0
Resolution: fixed
Status: assignedclosed

Updated patch applied as r2637.

comment:10 by Christopher Lenz, 14 years ago

Milestone: 1.00.10

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.