Edgewall Software
Modify

Opened 19 years ago

Closed 19 years ago

Last modified 18 years ago

#1634 closed defect (fixed)

Wiki-processor doesn't honor xhtml specs.

Reported by: Rede Owned by: Matthew Good
Priority: normal Milestone:
Component: wiki system Version: devel
Severity: minor Keywords: Patch
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

This is somewhat related to #1616.

Attached patch follows literally xhtml tag nesting. Closing tag must be on same nesting level as closing tag, otherwise it will open a new tag. I.e. __~~foo __bar~~ Will only open new tags since "closing" underline and oversrike tags are in wrong nesting level.

All open tags are forcibly closed at end of paragraph.

Attachments (1)

trac-1634-fix-r1757.patch (2.9 KB ) - added by Rede 19 years ago.
xhtml tagnesting fix.

Download all attachments as: .zip

Change History (8)

by Rede, 19 years ago

Attachment: trac-1634-fix-r1757.patch added

xhtml tagnesting fix.

comment:1 by Rede, 19 years ago

Version: 0.8.1devel

comment:2 by Matthew Good, 19 years ago

Owner: changed from Jonas Borgström to Matthew Good

Good point on the XHTML stuff.

However, I'd rather have:

__~~foo __bar~~

render as:

<u><del>foo </del></u><del>bar</del>

So, closing one formatting style would also close the stack above it, then reapply the above stack . This should also work better with the bold/italic formatting since it would also allow you to mix the tags and only partially overlap the sections.

I'll take another look at this patch tomorrow.

comment:3 by Rede, 19 years ago

Good point there. Actually this is more matter of taste… Which is proper workflow: to make user keepup taglevels (which in deed creates problems), or do it way you proposed.

I could give +1 to your proposal, since it would be more flexible, and will be more relaxed for user. (e.g. you really don't have to pay attention to order of tags)

comment:4 by Matthew Good, 19 years ago

Resolution: fixed
Status: newclosed

This has been fixed with [1773]

There is a slight caveat when the closing tags are out of order:

__~~outoforderclosetags__~~
<span class="underline"><del>outoforderclosetags</del></span><del></del>

Note the empty <del></del> at the end. I'm not really sure how to avoid this in this scenario. However, the above example __~~foo __bar~~ works as expected since the closing tags are not immediately next to each other.

comment:5 by Matthew Good, 19 years ago

Resolution: fixed
Status: closedreopened

Hmm, I also just realized that

''italic'''''bold'''

produces an empty <strong> block before the closing </i>. I'll investigate a solution.

comment:6 by Matthew Good, 19 years ago

Resolution: fixed
Status: reopenedclosed

[1782] fixes the ordering of the HTML tags for side-by-side italic and bold.

comment:7 by Rede, 19 years ago

For the record:

''__italicunderline'''''boldunderline__'''

Renders as: italicunderlineboldunderline

It is incorrect result (actually in both, visually and XHTML-standardically).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Matthew Good.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Matthew Good to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.