Edgewall Software
Modify ↓

Opened 20 years ago

Closed 20 years ago

Last modified 18 years ago

#1616 closed defect (fixed)

Wiki-processor renders bold-italic incorrectly.

Reported by: Rede Owned by: Christopher Lenz
Priority: low Milestone: 0.9
Component: wiki system Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Trac renders incorrectly list of bold-italic entries.

'''''view''''', '''''create''''', '''''modify''''' and '''''admin'''''

Renders as:

One, Two, Three and Four

Attachments (5)

trac-1616-fix-r1753.patch​ (1.0 KB ) - added by Rede 20 years ago.
Proposed patch
trac-1616-fix-r1753.2.patch​ (1.0 KB ) - added by Rede 20 years ago.
Second patch
formatter.py​ (3.0 KB ) - added by Rede 20 years ago.
Test cases
formatter.2.py​ (3.7 KB ) - added by Rede 20 years ago.
Changed hardcoded linechanges to os.linesep
trac-1616-fix-r1756.patch​ (2.7 KB ) - added by Rede 20 years ago.
Patch which contains tests in right place.

Download all attachments as: .zip

Change History (13)

comment:1 by Rede, 20 years ago

And of course visible list should have read:

'''''One''''', '''''Two''''', '''''Three''''' and '''''Four'''''

But you got the idea.. :)

by Rede, 20 years ago

Attachment: trac-1616-fix-r1753.patch​ added

Proposed patch

comment:2 by Rede, 20 years ago

Bug was that it closed all tags that were opened (but not closed) after closing tag.

I.e. following produced also faulty output __'''foo__ bar''' renders as : foo bar

Attached proposed patch. It closes only last occurence of open tag, not all tags after closing tag.

comment:3 by Christopher Lenz, 20 years ago

Component: general → ticket system
Milestone: → 0.9
Owner: changed from Jonas Borgström to Christopher Lenz
Priority: normal → low
Status: new → assigned

Any chance you could provide test cases that verify this functionality?

comment:4 by Rede, 20 years ago

New patch:

Now open tags are closed end of paragraph.

New file:

trac/tests/formatter.py - testcases to run against patch.

by Rede, 20 years ago

Attachment: trac-1616-fix-r1753.2.patch​ added

Second patch

by Rede, 20 years ago

Attachment: formatter.py​ added

Test cases

by Rede, 20 years ago

Attachment: formatter.2.py​ added

Changed hardcoded linechanges to os.linesep

comment:5 by Rede, 20 years ago

Nice to be dummy for a while - I just tests in right file now.. :)

by Rede, 20 years ago

Attachment: trac-1616-fix-r1756.patch​ added

Patch which contains tests in right place.

comment:6 by Christopher Lenz, 20 years ago

Component: ticket system → wiki

comment:7 by Christopher Lenz, 20 years ago

As far as I can tell, the attached patch should also fix #245.

comment:8 by Christopher Lenz, 20 years ago

Resolution: → fixed
Status: assigned → closed

Patch applied in [1757]. Thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christopher Lenz to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.