Linking to non-existant changeset causes error instead of warning

[David Kramer <david@…>]

I was fooling around with the demo site, especially with TrackLinks. I tried putting a link to a non-existant changeset (since I don't know what revisions are present in your subversion repository), and got the following:

 Trac detected an internal error:

unpack non-sequence

If you think this really should work and you can reproduce it. Then you should consider to report this problem to the Trac team.

Go to http://trac.edgewall.com/ and create a new ticket where you describe the problem, how to reproduce it. Don't forget to include the python traceback found below.

TracGuide — The Trac User and Administration Guide
Python traceback

Traceback (most recent call last):
  File "/usr/lib/python2.3/site-packages/trac/web/modpython_frontend.py", line 265, in handler
    dispatch_request(mpr.path_info, mpr, env)
  File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 419, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 283, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/lib/python2.3/site-packages/trac/Changeset.py", line 60, in process_request
    chgset = repos.get_changeset(rev)
  File "/usr/lib/python2.3/site-packages/trac/versioncontrol/cache.py", line 49, in get_changeset
    return CachedChangeset(rev, self.db, self.authz)
  File "/usr/lib/python2.3/site-packages/trac/versioncontrol/cache.py", line 124, in __init__
    date, author, message = cursor.fetchone()
TypeError: unpack non-sequence

I would think a simple message saying the changeset number was invalid, like for milestones, would be an improvement.

See the link to changeset 1759 in ​ticket 23 in the demo system for the link in question.

[Christopher Lenz]

The link in the ticket you referenced actually looks good AFAICT.

[Christian Boos]

Fixed in [1766]