Move ticket's status-related visible strings from Python to templates

[pkou at ua.fm]

There are several places in Trac Python code that define strings/parameters to be displayed in HTML. Areas of interest are the places where HTML text/code depends on ticket status directly. These places need to refactor with the following goals:

• Move HTML formatting from Python code to ClearSilver templates or CSS;
• Make the places status-independant.

The following places have been identified:

1. trac/Query.py, function render_macro, preparation of a compact report:
   1. CSS class name depends on ticket status.
      Suggested change: Define CSS styles for every ticket status and specify CSS class regardless of ticket status.
   2. Depending on ticket status, it is added to Summary field.
      Suggested change: Add ticket status for all tickets? Or remove?
2. trac/wiki/formatter.py, function _make_ticket_link, creating an URL for ticket reference in wiki:
   1. CSS class name depends on ticket status.
      Suggested change: Define CSS styles for every ticket status and specify CSS class regardless of ticket status.
   2. Ticket status is added to popup text for some statuses.
      Suggested change: Add ticket status for all tickets.
3. trac/Ticket.py, function TicketModule.get_timeline_events, formatting title for an item in timeline:
   1. Text for timeline title depends on ticket status (verbs variable).
      Suggested change: (easy) put ticket status - bad look for new tickets, (hard) - format ticket title in template depending on ticket type.

Goal of the changes is to make Trac Python code independent from ticket status. This will allow use existing code without changes when new statuses are introduced or when they are changed.

(In preparation for #869)

[pkou at ua.fm]

I am not sure that suggested changes are the better way for resolving this problem. Thus, review of the proposed changes is necessary before making them (or just implement as you think it is appropriate).

[Christopher Lenz]

Point 1 was fixed in [1831].

[Christopher Lenz]

Point 2 fixed in [1948].

Point 3 is tricky indeed. Just putting the status in the title would be bad IMHO. Moving this into the templates is no longer an option as the template no longer does the formatting of the individual timeline event titles. No bright idea here ATM.

[Christopher Lenz]

I don't see a good way to resolve point 3 for now. Postponing…

[Eli Carter]

What do we need to do with this now that WorkFlow is in trunk?

[pkou at ua.fm]

I think this should be closed safely.

[osimons]

Replying to pkou at ua.fm:

I think this should be closed safely.

Original reporter says 'close', so I'm closing… If nothing else, point 3 should also be resolved by the timeline-refactoring merge of [6158] for 0.11 (and most other things '0.11').