Edgewall Software

Opened 16 years ago

Closed 16 years ago

#1544 closed defect (fixed)

change/restore ticket field leads to adding fake ticket change

Reported by: pkou at ua.fm Owned by: Christopher Lenz
Priority: normal Milestone: 0.9
Component: ticket system Version: 0.8
Severity: trivial Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:


When ticket field is changed, then original value is saved for tracking ticket changes. However, if a field is changed to some value and then to original value, then this change is tracked.

Patch for trunk:

Index: Ticket.py
--- Ticket.py   (revision 1667)
+++ Ticket.py   (working copy)
@@ -53,6 +53,8 @@
         if not self._old.has_key(name):
             self._old[name] = self.get(name, None)
+        else if self._old[name] == value:
+            del self._old[name]
         dict.__setitem__(self, name, value)

     def _forget_changes(self):

(In preparation to #869)

Attachments (0)

Change History (3)

comment:1 by Christopher Lenz, 16 years ago

Owner: changed from Jonas Borgström to Christopher Lenz
Status: newassigned

comment:2 by Christopher Lenz, 16 years ago

Heh, else if doesn't really work in python ;-)

comment:3 by Christopher Lenz, 16 years ago

Resolution: fixed
Status: assignedclosed

Fixed in [1668].

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christopher Lenz to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.