Edgewall Software
Modify

Opened 19 years ago

Closed 19 years ago

#1518 closed defect (fixed)

changeset error when the svn:mime-type property has the charset

Reported by: zn@… Owned by: Christopher Lenz
Priority: normal Milestone: 0.8.2
Component: version control/changeset view Version: 0.8.1
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

 Trac detected an internal error:

HtmlDiffEditor instance has no attribute 'log'
Traceback (most recent call last):
  File "/usr/lib/python2.3/site-packages/trac/ModPythonHandler.py", line 195, in handler
    core.dispatch_request(mpr.path_info, args, mpr, env)
  File "/usr/lib/python2.3/site-packages/trac/core.py", line 441, in dispatch_request
    module.run()
  File "/usr/lib/python2.3/site-packages/trac/Module.py", line 46, in run
    disp()
  File "/usr/lib/python2.3/site-packages/trac/Changeset.py", line 243, in display
    self.render_diffs()
  File "/usr/lib/python2.3/site-packages/trac/Changeset.py", line 239, in render_diffs
    0, 1, 0, 1, self.pool)
  File "/usr/lib/python2.3/site-packages/trac/Changeset.py", line 112, in apply_textdelta
    self.print_diff (*file_baton)
  File "/usr/lib/python2.3/site-packages/trac/Changeset.py", line 70, in print_diff
    self.log.debug("Charset %s selected" % charset)
AttributeError: HtmlDiffEditor instance has no attribute 'log'

Attachments (0)

Change History (5)

comment:1 by kcwu, 19 years ago

it's fixed in [1109].

workaround for 0.8.x with following patch

--- Changeset.py.orig   Thu May 19 03:19:06 2005
+++ Changeset.py        Thu May 19 03:19:10 2005
@@ -67,7 +67,6 @@
         ctpos = mime_type and mime_type.find('charset=') or -1
         if ctpos >= 0:
             charset = mime_type[ctpos + 8:]
-            self.log.debug("Charset %s selected" % charset)
         else:
             charset = self.env.get_config('trac', 'default_charset', 'iso-8859-15')

comment:2 by Christopher Lenz <cmlenz@…>, 19 years ago

Milestone: 0.8.2
Owner: changed from Jonas Borgström to anonymous
Status: newassigned

comment:3 by Christopher Lenz, 19 years ago

Owner: changed from anonymous to Christopher Lenz
Status: assignednew

Oops, forgot to login.

comment:4 by Christopher Lenz, 19 years ago

Status: newassigned

comment:5 by Christopher Lenz, 19 years ago

Resolution: fixed
Status: assignedclosed

Fixed in [1698].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christopher Lenz to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.