Edgewall Software

Opened 16 years ago

Closed 15 years ago

Last modified 14 years ago

#1415 closed defect (duplicate)

Allow '+' in dynamic variable value, or allow to configure regexp

Reported by: bitserf@… Owned by: Jonas Borgström
Priority: normal Milestone:
Component: general Version: 0.8.1
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:



We were having problems with our downloadable reports, as we authenticate all users against a Domain Controller using PAM. Samba translates the '\' in the username DOMAIN\user into DOMAIN+user.

The reports don't like this, as the dynvars_disallowed_value_chars_re regular expression does not include the '+' character.

In addition, the backtrace is not very useful, as the error occurs before self.error/self.rows/self.cols has any value, so the error message is "Report instance has no attribute 'error'" instead of the real message "report failed: xxx" as I expected the code would produce.

The error occurred against 0.8, but looking at the 0.8.1 code, it seems that it would still occur.

Our current (now working) regex:

dynvars_disallowed_value_chars_re = re.compile('[^a-zA-Z0-9-_@.,\+]')

Attachments (0)

Change History (2)

comment:1 by bitserf@…, 16 years ago

To clarify: The error occurs because the request argument 'USER' contains a name like 'DOMAIN+username'.

comment:2 by Matthew Good, 15 years ago

Resolution: duplicate
Status: newclosed

This was addressed in #2536

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.