Edgewall Software
Modify

Opened 5 days ago

Last modified 23 hours ago

#13869 assigned defect

Addresses in smtp_always_bcc listed in Cc header when use_public_cc is enabled

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.6.1
Component: notification Version: 1.2
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

I noticed that the addresses in [notification] smtp_always_bcc are listed in Cc header of the notification mail when [notification] use_public_cc is enabled.

Return-Path: <1.4-sqlite@trac.test>
X-Original-To: 1.4-sqlite+bcc@trac.test
Received: from [127.0.0.1] (unknown [192.168.11.122])
	by localhost (Postfix) with ESMTP id 45AF682414A;
	Mon, 17 Feb 2025 02:12:45 +0900 (JST)
Content-Type: multipart/related;
 boundary="===============8362590658671035220=="
MIME-Version: 1.0
X-Mailer: Trac 1.6, by Edgewall Software
X-Trac-Version: 1.6
X-Trac-Project: 1.4-stable
X-URL:
X-Trac-Realm: ticket
Precedence: bulk
Auto-Submitted: auto-generated
Message-ID: <017.03bc072e7921ee7e4a4d7bc7a9e1c8e3@trac.test>
Date: Sun, 16 Feb 2025 17:12:45 -0000
To: undisclosed-recipients: ;
From: "1.4-stable" <1.4-sqlite@trac.test>
Cc: 1.4-sqlite+bcc@trac.test, 1.4-sqlite+cc@trac.test
Reply-To: <>
X-Trac-Ticket-ID: 27
X-Trac-Ticket-URL: http://192.168.11.122:3000/1.4-sqlite/ticket/27
Subject: [1.4-stable] #27: smtp_always_bcc testing

Adding a test case to NotificationTestCase.test_bcc_privacy, the same issue is able to be raised.

  • trac/ticket/tests/notification.py

    diff --git a/trac/ticket/tests/notification.py b/trac/ticket/tests/notification.py
    index c940241b7..47f49deb6 100644
    a b class NotificationTestCase(unittest.TestCase):  
    482482            for rcpt in bccrcpt:
    483483                # Check the message has actually been sent to the recipients
    484484                self.assertIn(rcpt, rcptlist)
     485                # Check the recipients have not listed in the Cc header
     486                self.assertNotIn(rcpt, cc)
    485487        for public in False, True:
    486488            run_bcc_feature(public)
    487489
======================================================================
FAIL: test_bcc_privacy (trac.ticket.tests.notification.NotificationTestCase)
Visibility of recipients
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jun66j5/src/tracdev/git/trac/ticket/tests/notification.py", line 487, in test_bcc_privacy
    run_bcc_feature(public)
  File "/home/jun66j5/src/tracdev/git/trac/ticket/tests/notification.py", line 485, in run_bcc_feature
    self.assertNotIn(rcpt, cc)
AssertionError: 'joe.foobar@example.net' unexpectedly found in ['joe.bar@example.net', 'joe.foobar@example.net', 'joe.user@example.net']

Attachments (0)

Change History (4)

comment:1 by Ryan J Ollos, 5 days ago

Description: modified (diff)

comment:2 by Ryan J Ollos, 4 days ago

Should we release 1.6.1 soon?

comment:3 by Jun Omae, 2 days ago

Agreed. The issue is introduced in 1.2 and doesn't seem to be noticed by anyone yet but I think we should release the fixes of this issue and #13786 as 1.6.1.

comment:4 by Jun Omae, 23 hours ago

Proposed changes in [3a6654167/jomae.git] (jomae.git@t13869).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as assigned The owner will remain Jun Omae.
The ticket will be disowned. Next status will be 'new'.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.