Modify ↓
Opened 10 months ago
Closed 7 months ago
#13740 closed defect (fixed)
Batch modification forms can be used incorrectly by users without TICKET_BATCH_MODIFY
Reported by: | Jun Omae | Owned by: | Jun Omae |
---|---|---|---|
Priority: | normal | Milestone: | 1.6.1 |
Component: | query system | Version: | 1.4.1 |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: |
Fixed incorrectly showing batch modify feature even for users without TICKET_BATCH_MODIFY. |
||
API Changes: | |||
Internal Changes: |
Description
The issue is introduced in [17236] (1.4.1dev, #13242). I noticed it by the following javascript error raised when visiting anonymously query page:
Uncaught TypeError: $(...).showOnPreview is not a function at HTMLDocument.<anonymous> (query:885:26) at e (jquery.js:2:30310) at t (jquery.js:2:30612)
-
trac/ticket/templates/query.html
diff --git a/trac/ticket/templates/query.html b/trac/ticket/templates/query.html index 6cd43de9e..3dface0f3 100644
a b 333 333 </form> 334 334 335 335 # include 'query_results.html' 336 # if tickets :336 # if tickets and batch_modify: 337 337 # include 'batch_modify.html' ignore missing 338 338 # endif 339 339
Attachments (0)
Change History (1)
comment:1 by , 7 months ago
Release Notes: | modified (diff) |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
Committed with unit tests in [17774] and merged in [17775].