Edgewall Software
Modify ↓

Opened 3 months ago

Closed 13 days ago

#13740 closed defect (fixed)

Batch modification forms can be used incorrectly by users without TICKET_BATCH_MODIFY

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.6.1
Component: query system Version: 1.4.1
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Fixed incorrectly showing batch modify feature even for users without TICKET_BATCH_MODIFY.

API Changes:
Internal Changes:

Description

The issue is introduced in [17236] (1.4.1dev, #13242). I noticed it by the following javascript error raised when visiting anonymously query page: 

Uncaught TypeError: $(...).showOnPreview is not a function
    at HTMLDocument.<anonymous> (query:885:26)
    at e (jquery.js:2:30310)
    at t (jquery.js:2:30612)

  • trac/ticket/templates/query.html 

    diff --git a/trac/ticket/templates/query.html b/trac/ticket/templates/query.html
index 6cd43de9e..3dface0f3 100644
    a b  
    333333      </form>
    334334
    335335      # include 'query_results.html'
    336       # if tickets:
     336      # if tickets and batch_modify:
    337337      #   include 'batch_modify.html' ignore missing
    338338      # endif
    339339

Attachments (0)

Change History (1)

comment:1 by Jun Omae, 13 days ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Committed with unit tests in [17774] and merged in [17775].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.