ValueError not logged when a unicode instance is passed to req.send()

[Jun Omae]

I noticed that the raised ValueError is not logged when a unicode instance is passed to req.send() and the response is empty. The issue occurs regardless of the [trac] use_chunked_encoding option.

The behavior appears to have been introduced in [17055] (#13038). The change was based on my suggestion (my fault).

trac/web/main.py

@@ -640 +640 @@
         except RequestDone as req_done:
             resp = req_done.iterable
     except HTTPException as e:
-        if not req.response_started:
-            _send_user_error(req, env, e)
+        _send_user_error(req, env, e)
     except Exception:
-        if not req.response_started:
-            send_internal_error(env, req, sys.exc_info())
+        send_internal_error(env, req, sys.exc_info())
     else:
         resp = resp or req._response or []
     finally:
@@ -706 +704 @@
         env.log.warning('[%s] %s, %r, referrer %r',
                         req.remote_addr, exception_to_unicode(e),
                         req, req.environ.get('HTTP_REFERER'))
+    if req.response_started:
+        return
     data = {'title': e.title, 'type': 'TracError', 'message': e.message,
             'frames': [], 'traceback': None}
     if e.code == 403 and not req.is_authenticated:
@@ -721 +721 @@
         env.log.error("[%s] Internal Server Error: %r, referrer %r%s",
                       req.remote_addr, req, req.environ.get('HTTP_REFERER'),
                       exception_to_unicode(exc_info[1], traceback=True))
+    if req.response_started:
+        return
     message = exception_to_unicode(exc_info[1])
     traceback = get_last_traceback()

(I plan to apply the patch to 1.0-stable and 1.2-stable as well)

[Jun Omae]

Fixed in [17695:17698].