`#!html` processor incorrectly closes at end of wiki text, not `}}}`

[anonymous]

If I set the style in a {{{#!html ... }}} section, this leaks into the rest of the wicket or wiki page:

The text I used is:

= HTML Leak
{{{#!html
<div  style="background-color:lightgrey;">
<h4>Header</h4>
<p>Some text...</p>
}}}
Background leaks here...
= Next section
Background leaks here too...

I would expect all HTML settings and other features that I use or changes that I make inside a {{{ ... }}} block, that they are limited to this block.

[geert.linders@…]

Oops! Forgot to add my email address.

[Jun Omae]

Thanks for the reporting.

Another example

= Header 1
Pre text.
{{{#!html
<div style="border:2px solid orange;padding:1em">
<h4>Header 4</h4>
<p>Some text...</p>
}}}
Post text.

= Header 2
Pre text.
{{{#!html
<div style="border:2px solid blue;padding:1em">
<h4>Header 4</h4>
<p>Some text...</p>
}}}
Post text.

Result:

[Jun Omae]

Ah. That is caused by missing </div> in the #!html processor.

{{{#!html
<div  style="background-color:lightgrey;">
<h4>Header</h4>
<p>Some text...</p>
</div>        <!--  MISSING -->
}}}

[geert.linders@…]

I know the </div> is missing. But that is not the issue here.

Anything you do inside {{{ ... }}} should not affect the rest of the ticket or wiki page.

The closing }}} should restore the style sheet of the ticket or wiki page.

[Jun Omae]

Replying to geert.linders@…:

I know the </div> is missing. But that is not the issue here.

Anything you do inside {{{ ... }}} should not affect the rest of the ticket or wiki page.

The closing }}} should restore the style sheet of the ticket or wiki page.

You know? You didn't explain that. Well, add </div> as a workaround.

Hm. Document for #!html processor says in WikiHtml:

The filtering is done by ​Genshi and the output will be a well-formed fragment of HTML. This means that you cannot use two HTML blocks, one for opening a <div> and another for closing it, in order to wrap arbitrary wiki text.

Currently, the output of #!html processor with unbalanced tags is not a well-formed fragment.

>>> from trac.test import EnvironmentStub, MockRequest
>>> from trac.wiki.formatter import format_to_html
>>> from trac.web.chrome import web_context
>>> env = EnvironmentStub()
>>> req = MockRequest(env)
>>> context = web_context(req)
>>> text = """\
... aaa
... {{{#!html
... <div>
... text
... }}}
... bbb
... """
>>> print(format_to_html(env, context, text))
<p>
aaa
</p>
<div>
text
<p>       # <== </div> should be automatically added before <p>
bbb
</p>

[geert.linders@…]

Sorry I didn't mention the unbalanced <div> tag.

So it seems we do have an issue. Although probably a minor one because there is a simple workaround.