#13280 closed defect (fixed)
Skip commits on AppVeyor
Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
---|---|---|---|
Priority: | normal | Milestone: | 1.0.20 |
Component: | general | Version: | |
Severity: | normal | Keywords: | appveyor |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Appveyor will not run builds when commits contain only files in |
Description
32546122 ran even though the message contained [skip ci]
. It looks like we need to setup commit filtering.
Also, we can configure to skip commits matching only files in trac/locale
, in case we forget to specify [skip ci]
.
Attachments (0)
Change History (8)
comment:1 by , 5 years ago
comment:2 by , 5 years ago
Internal Changes: | modified (diff) |
---|
comment:3 by , 5 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Committed in [17286:17289].
comment:4 by , 4 years ago
Might be more effective to use a rule like the following:
only_commits: files: - .appveyor.yml - contrib/appveyor.ps1 - setup.py - trac/**/*.py - trac/**/*.html - tracopt/**/*.py - tracopt/**/*.html
comment:5 by , 4 years ago
The path is appended each of the 3 times the AppVeyor script is run: see build 33182015.
Trac-Install
Path not printed
But, presumably it would be:
PYTHONPATH=.:C:\projects\dependencies\2.7\svn-win32-1.8.15\python
Trac-Build
Path appended twice:
PYTHONPATH=.:C:\projects\dependencies\2.7\svn-win32-1.8.15\python;C:\projects\dependencies\2.7\svn-win32-1.8.15\python;
Trac-Tests
Path appended thrice:
PYTHONPATH=.:C:\projects\dependencies\2.7\svn-win32-1.8.15\python;C:\projects\dependencies\2.7\svn-win32-1.8.15\python;C:\projects\dependencies\2.7\svn-win32-1.8.15\python;
Proposed change:
comment:8 by , 4 years ago
r17470 and r17471 didn't run on AppVeyor. Added trac/**/*.txt
to only_commits
patterns in [17472:17475]:
$ find trac -name "*.txt"
trac/web/tests/console-tests.txt
trac/tests/attachment-console-tests.txt
trac/tests/console-tests.txt
trac/admin/tests/console-tests.txt
trac/wiki/tests/wiki-tests.txt
trac/wiki/tests/wikicreole-tests.txt
trac/versioncontrol/tests/console-tests.txt
trac/versioncontrol/templates/revisionlog.txt
trac/ticket/tests/console-tests.txt
trac/ticket/templates/batch_ticket_notify_email.txt
trac/ticket/templates/ticket_notify_email.txt
That differs from Travis CI and I'm not sure we want to start putting
[skip ci]
in the title.We could cover most cases with:
.appveyor.yml